From 8682a3ffd989d0214e92ca161777d6c6696e44cb Mon Sep 17 00:00:00 2001 From: Prianka Liz Kariat Date: Thu, 23 Mar 2023 19:58:03 +0530 Subject: [PATCH] Updated formatted --- .../utils/sources/MPPBaseOptions+Helpers.h | 3 +- .../MPPImageClassifierTests.m | 100 ++++++++++-------- .../vision/utils/sources/MPPImage+TestUtils.h | 11 +- .../vision/utils/sources/MPPImage+TestUtils.m | 19 ++-- .../core/sources/MPPVisionTaskRunner.mm | 2 +- 5 files changed, 75 insertions(+), 60 deletions(-) diff --git a/mediapipe/tasks/ios/core/utils/sources/MPPBaseOptions+Helpers.h b/mediapipe/tasks/ios/core/utils/sources/MPPBaseOptions+Helpers.h index d1810d56b..408d1a3e2 100644 --- a/mediapipe/tasks/ios/core/utils/sources/MPPBaseOptions+Helpers.h +++ b/mediapipe/tasks/ios/core/utils/sources/MPPBaseOptions+Helpers.h @@ -20,7 +20,8 @@ NS_ASSUME_NONNULL_BEGIN @interface MPPBaseOptions (Helpers) - (void)copyToProto:(mediapipe::tasks::core::proto::BaseOptions *)baseOptionsProto; -- (void)copyToProto:(mediapipe::tasks::core::proto::BaseOptions *)baseOptionsProto withUseStreamMode:(BOOL)useStreamMode; +- (void)copyToProto:(mediapipe::tasks::core::proto::BaseOptions *)baseOptionsProto + withUseStreamMode:(BOOL)useStreamMode; @end diff --git a/mediapipe/tasks/ios/test/vision/image_classifier/MPPImageClassifierTests.m b/mediapipe/tasks/ios/test/vision/image_classifier/MPPImageClassifierTests.m index 6be325756..e50fb1203 100644 --- a/mediapipe/tasks/ios/test/vision/image_classifier/MPPImageClassifierTests.m +++ b/mediapipe/tasks/ios/test/vision/image_classifier/MPPImageClassifierTests.m @@ -23,7 +23,8 @@ static NSString *const kQuantizedModelName = @"mobilenet_v1_0.25_224_quant"; static NSDictionary *const kBurgerImage = @{@"name" : @"burger", @"type" : @"jpg"}; static NSDictionary *const kBurgerRotatedImage = @{@"name" : @"burger_rotated", @"type" : @"jpg"}; static NSDictionary *const kMultiObjectsImage = @{@"name" : @"multi_objects", @"type" : @"jpg"}; -static NSDictionary *const kMultiObjectsRotatedImage = @{@"name" : @"multi_objects_rotated", @"type" : @"jpg"}; +static NSDictionary *const kMultiObjectsRotatedImage = + @{@"name" : @"multi_objects_rotated", @"type" : @"jpg"}; static const int kMobileNetCategoriesCount = 1001; static NSString *const kExpectedErrorDomain = @"com.google.mediapipe.tasks"; @@ -112,7 +113,7 @@ static NSString *const kExpectedErrorDomain = @"com.google.mediapipe.tasks"; #pragma mark Assert Classify Results --(MPPImage *)imageWithFileInfo:(NSDictionary *)fileInfo { +- (MPPImage *)imageWithFileInfo:(NSDictionary *)fileInfo { MPPImage *image = [MPPImage imageFromBundleWithClass:[MPPImageClassifierTests class] fileName:fileInfo[@"name"] ofType:fileInfo[@"type"]]; @@ -121,11 +122,12 @@ static NSString *const kExpectedErrorDomain = @"com.google.mediapipe.tasks"; return image; } --(MPPImage *)imageWithFileInfo:(NSDictionary *)fileInfo orientation:(UIImageOrientation)orientation { +- (MPPImage *)imageWithFileInfo:(NSDictionary *)fileInfo + orientation:(UIImageOrientation)orientation { MPPImage *image = [MPPImage imageFromBundleWithClass:[MPPImageClassifierTests class] fileName:fileInfo[@"name"] ofType:fileInfo[@"type"] - orientation:orientation]; + orientation:orientation]; XCTAssertNotNil(image); return image; @@ -173,9 +175,9 @@ static NSString *const kExpectedErrorDomain = @"com.google.mediapipe.tasks"; } - (void)assertResultsOfClassifyImageWithFileInfo:(NSDictionary *)fileInfo - usingImageClassifier:(MPPImageClassifier *)imageClassifier - expectedCategoriesCount:(NSInteger)expectedCategoriesCount - equalsCategories:(NSArray *)expectedCategories { + usingImageClassifier:(MPPImageClassifier *)imageClassifier + expectedCategoriesCount:(NSInteger)expectedCategoriesCount + equalsCategories:(NSArray *)expectedCategories { MPPImage *mppImage = [self imageWithFileInfo:fileInfo]; [self assertResultsOfClassifyImage:mppImage @@ -242,11 +244,13 @@ static NSString *const kExpectedErrorDomain = @"com.google.mediapipe.tasks"; - (void)testClassifyWithModelPathAndFloatModelSucceeds { MPPImageClassifier *imageClassifier = [self imageClassifierFromModelFileWithName:kFloatModelName]; - [self assertResultsOfClassifyImageWithFileInfo:kBurgerImage - usingImageClassifier:imageClassifier - expectedCategoriesCount:kMobileNetCategoriesCount - equalsCategories:[MPPImageClassifierTests - expectedResultCategoriesForClassifyBurgerImageWithFloatModel]]; + [self + assertResultsOfClassifyImageWithFileInfo:kBurgerImage + usingImageClassifier:imageClassifier + expectedCategoriesCount:kMobileNetCategoriesCount + equalsCategories: + [MPPImageClassifierTests + expectedResultCategoriesForClassifyBurgerImageWithFloatModel]]; } - (void)testClassifyWithOptionsAndFloatModelSucceeds { @@ -257,11 +261,13 @@ static NSString *const kExpectedErrorDomain = @"com.google.mediapipe.tasks"; MPPImageClassifier *imageClassifier = [self imageClassifierWithOptionsSucceeds:options]; - [self assertResultsOfClassifyImageWithFileInfo:kBurgerImage - usingImageClassifier:imageClassifier - expectedCategoriesCount:maxResults - equalsCategories:[MPPImageClassifierTests - expectedResultCategoriesForClassifyBurgerImageWithFloatModel]]; + [self + assertResultsOfClassifyImageWithFileInfo:kBurgerImage + usingImageClassifier:imageClassifier + expectedCategoriesCount:maxResults + equalsCategories: + [MPPImageClassifierTests + expectedResultCategoriesForClassifyBurgerImageWithFloatModel]]; } - (void)testClassifyWithQuantizedModelSucceeds { @@ -279,9 +285,9 @@ static NSString *const kExpectedErrorDomain = @"com.google.mediapipe.tasks"; displayName:nil] ]; [self assertResultsOfClassifyImageWithFileInfo:kBurgerImage - usingImageClassifier:imageClassifier - expectedCategoriesCount:maxResults - equalsCategories:expectedCategories]; + usingImageClassifier:imageClassifier + expectedCategoriesCount:maxResults + equalsCategories:expectedCategories]; } - (void)testClassifyWithScoreThresholdSucceeds { @@ -297,9 +303,9 @@ static NSString *const kExpectedErrorDomain = @"com.google.mediapipe.tasks"; displayName:nil] ]; [self assertResultsOfClassifyImageWithFileInfo:kBurgerImage - usingImageClassifier:imageClassifier - expectedCategoriesCount:expectedCategories.count - equalsCategories:expectedCategories]; + usingImageClassifier:imageClassifier + expectedCategoriesCount:expectedCategories.count + equalsCategories:expectedCategories]; } - (void)testClassifyWithAllowListSucceeds { @@ -326,9 +332,9 @@ static NSString *const kExpectedErrorDomain = @"com.google.mediapipe.tasks"; ]; [self assertResultsOfClassifyImageWithFileInfo:kBurgerImage - usingImageClassifier:imageClassifier - expectedCategoriesCount:expectedCategories.count - equalsCategories:expectedCategories]; + usingImageClassifier:imageClassifier + expectedCategoriesCount:expectedCategories.count + equalsCategories:expectedCategories]; } - (void)testClassifyWithDenyListSucceeds { @@ -358,9 +364,9 @@ static NSString *const kExpectedErrorDomain = @"com.google.mediapipe.tasks"; ]; [self assertResultsOfClassifyImageWithFileInfo:kBurgerImage - usingImageClassifier:imageClassifier - expectedCategoriesCount:expectedCategories.count - equalsCategories:expectedCategories]; + usingImageClassifier:imageClassifier + expectedCategoriesCount:expectedCategories.count + equalsCategories:expectedCategories]; } - (void)testClassifyWithRegionOfInterestSucceeds { @@ -377,7 +383,7 @@ static NSString *const kExpectedErrorDomain = @"com.google.mediapipe.tasks"; displayName:nil] ]; MPPImage *image = [self imageWithFileInfo:kMultiObjectsImage]; - + // roi around soccer ball MPPImageClassifierResult *imageClassifierResult = [imageClassifier classifyImage:image @@ -412,7 +418,8 @@ static NSString *const kExpectedErrorDomain = @"com.google.mediapipe.tasks"; ]; - MPPImage *image = [self imageWithFileInfo:kBurgerRotatedImage orientation:UIImageOrientationRight]; + MPPImage *image = [self imageWithFileInfo:kBurgerRotatedImage + orientation:UIImageOrientationRight]; [self assertResultsOfClassifyImage:image usingImageClassifier:imageClassifier @@ -434,7 +441,8 @@ static NSString *const kExpectedErrorDomain = @"com.google.mediapipe.tasks"; categoryName:@"folding chair" displayName:nil] ]; - MPPImage *image = [self imageWithFileInfo:kMultiObjectsRotatedImage orientation:UIImageOrientationRight]; + MPPImage *image = [self imageWithFileInfo:kMultiObjectsRotatedImage + orientation:UIImageOrientationRight]; // roi around folding chair MPPImageClassifierResult *imageClassifierResult = @@ -606,8 +614,7 @@ static NSString *const kExpectedErrorDomain = @"com.google.mediapipe.tasks"; MPPImageClassifier *imageClassifier = [self imageClassifierWithOptionsSucceeds:options]; - - MPPImage *image = [self imageWithFileInfo:kBurgerImage]; + MPPImage *image = [self imageWithFileInfo:kBurgerImage]; for (int i = 0; i < 3; i++) { MPPImageClassifierResult *imageClassifierResult = [imageClassifier classifyVideoFrame:image @@ -615,8 +622,9 @@ static NSString *const kExpectedErrorDomain = @"com.google.mediapipe.tasks"; error:nil]; [self assertImageClassifierResult:imageClassifierResult hasExpectedCategoriesCount:maxResults - expectedCategories:[MPPImageClassifierTests - expectedResultCategoriesForClassifyBurgerImageWithFloatModel]]; + expectedCategories: + [MPPImageClassifierTests + expectedResultCategoriesForClassifyBurgerImageWithFloatModel]]; } } @@ -630,13 +638,14 @@ static NSString *const kExpectedErrorDomain = @"com.google.mediapipe.tasks"; options.completion = ^(MPPImageClassifierResult *result, NSError *error) { [self assertImageClassifierResult:result hasExpectedCategoriesCount:maxResults - expectedCategories:[MPPImageClassifierTests - expectedResultCategoriesForClassifyBurgerImageWithFloatModel]]; + expectedCategories: + [MPPImageClassifierTests + expectedResultCategoriesForClassifyBurgerImageWithFloatModel]]; }; MPPImageClassifier *imageClassifier = [self imageClassifierWithOptionsSucceeds:options]; - MPPImage *image = [self imageWithFileInfo:kBurgerImage]; + MPPImage *image = [self imageWithFileInfo:kBurgerImage]; XCTAssertTrue([imageClassifier classifyAsyncImage:image timestampMs:1 error:nil]); @@ -663,16 +672,17 @@ static NSString *const kExpectedErrorDomain = @"com.google.mediapipe.tasks"; options.completion = ^(MPPImageClassifierResult *result, NSError *error) { [self assertImageClassifierResult:result hasExpectedCategoriesCount:maxResults - expectedCategories:[MPPImageClassifierTests - expectedResultCategoriesForClassifyBurgerImageWithFloatModel]]; + expectedCategories: + [MPPImageClassifierTests + expectedResultCategoriesForClassifyBurgerImageWithFloatModel]]; }; MPPImageClassifier *imageClassifier = [self imageClassifierWithOptionsSucceeds:options]; - - // TODO: Mimic initialization from CMSampleBuffer as live stream mode is most likely to be used with the iOS camera. - // AVCaptureVideoDataOutput sample buffer delegates provide frames of type `CMSampleBuffer`. - MPPImage *image = [self imageWithFileInfo:kBurgerImage]; + // TODO: Mimic initialization from CMSampleBuffer as live stream mode is most likely to be used + // with the iOS camera. AVCaptureVideoDataOutput sample buffer delegates provide frames of type + // `CMSampleBuffer`. + MPPImage *image = [self imageWithFileInfo:kBurgerImage]; for (int i = 0; i < 3; i++) { XCTAssertTrue([imageClassifier classifyAsyncImage:image timestampMs:i error:nil]); diff --git a/mediapipe/tasks/ios/test/vision/utils/sources/MPPImage+TestUtils.h b/mediapipe/tasks/ios/test/vision/utils/sources/MPPImage+TestUtils.h index eb0edf6ab..9b45b2596 100644 --- a/mediapipe/tasks/ios/test/vision/utils/sources/MPPImage+TestUtils.h +++ b/mediapipe/tasks/ios/test/vision/utils/sources/MPPImage+TestUtils.h @@ -40,7 +40,8 @@ NS_ASSUME_NONNULL_BEGIN NS_SWIFT_NAME(imageFromBundle(class:filename:type:)); /** - * Loads an image from a file in an app bundle into a `MPPImage` object with the specified orientation. + * Loads an image from a file in an app bundle into a `MPPImage` object with the specified + * orientation. * * @param classObject The specified class associated with the bundle containing * the file to be loaded. @@ -52,10 +53,10 @@ NS_ASSUME_NONNULL_BEGIN * nil if it cannot load the image. */ + (nullable MPPImage *)imageFromBundleWithClass:(Class)classObject - fileName:(NSString *)name - ofType:(NSString *)type - orientation:(UIImageOrientation)imageOrientation - NS_SWIFT_NAME(imageFromBundle(class:filename:type:orientation:)); + fileName:(NSString *)name + ofType:(NSString *)type + orientation:(UIImageOrientation)imageOrientation + NS_SWIFT_NAME(imageFromBundle(class:filename:type:orientation:)); @end diff --git a/mediapipe/tasks/ios/test/vision/utils/sources/MPPImage+TestUtils.m b/mediapipe/tasks/ios/test/vision/utils/sources/MPPImage+TestUtils.m index 5421fd3bf..0b0ef9fbf 100644 --- a/mediapipe/tasks/ios/test/vision/utils/sources/MPPImage+TestUtils.m +++ b/mediapipe/tasks/ios/test/vision/utils/sources/MPPImage+TestUtils.m @@ -16,14 +16,17 @@ @interface UIImage (FileUtils) -+(nullable UIImage *)imageFromBundleWithClass:(Class)classObject fileName:(NSString *)name ofType:(NSString *)type; ++ (nullable UIImage *)imageFromBundleWithClass:(Class)classObject + fileName:(NSString *)name + ofType:(NSString *)type; @end @implementation UIImage (FileUtils) -+(nullable UIImage *)imageFromBundleWithClass:(Class)classObject fileName:(NSString *)name ofType:(NSString *)type { - ++ (nullable UIImage *)imageFromBundleWithClass:(Class)classObject + fileName:(NSString *)name + ofType:(NSString *)type { NSString *imagePath = [[NSBundle bundleForClass:classObject] pathForResource:name ofType:type]; if (!imagePath) return nil; @@ -35,17 +38,17 @@ @implementation MPPImage (TestUtils) + (nullable MPPImage *)imageFromBundleWithClass:(Class)classObject - fileName:(NSString *)name - ofType:(NSString *)type { + fileName:(NSString *)name + ofType:(NSString *)type { UIImage *image = [UIImage imageFromBundleWithClass:classObject fileName:name ofType:type]; return [[MPPImage alloc] initWithUIImage:image error:nil]; } + (nullable MPPImage *)imageFromBundleWithClass:(Class)classObject - fileName:(NSString *)name - ofType:(NSString *)type - orientation:(UIImageOrientation)imageOrientation { + fileName:(NSString *)name + ofType:(NSString *)type + orientation:(UIImageOrientation)imageOrientation { UIImage *image = [UIImage imageFromBundleWithClass:classObject fileName:name ofType:type]; return [[MPPImage alloc] initWithUIImage:image orientation:imageOrientation error:nil]; diff --git a/mediapipe/tasks/ios/vision/core/sources/MPPVisionTaskRunner.mm b/mediapipe/tasks/ios/vision/core/sources/MPPVisionTaskRunner.mm index 787dceeae..0ed447c01 100644 --- a/mediapipe/tasks/ios/vision/core/sources/MPPVisionTaskRunner.mm +++ b/mediapipe/tasks/ios/vision/core/sources/MPPVisionTaskRunner.mm @@ -138,7 +138,7 @@ static const NSInteger kMPPOrientationDegreesLeft = -270; } - (std::optional)processImagePacketMap:(const PacketMap &)packetMap - error:(NSError **)error { + error:(NSError **)error { if (_runningMode != MPPRunningModeImage) { [MPPCommonUtils createCustomError:error