From 837270387047cf8cfda03d60159bb05fe793e2e9 Mon Sep 17 00:00:00 2001 From: Mautisim Munir Date: Wed, 5 Oct 2022 20:56:45 +0500 Subject: [PATCH] removed redundant camera rotation parameter from PoseTrackingOptions --- mediapipe/examples/ios/bundle_id.bzl | 2 +- .../PoseTrackingViewController.mm | 9 ++++++++- .../solutions/posetracking_gpu/PoseTrackingOptions.h | 4 ++-- .../solutions/posetracking_gpu/PoseTrackingOptions.mm | 4 ++-- 4 files changed, 13 insertions(+), 6 deletions(-) diff --git a/mediapipe/examples/ios/bundle_id.bzl b/mediapipe/examples/ios/bundle_id.bzl index 4866b07c6..ca484abcd 100644 --- a/mediapipe/examples/ios/bundle_id.bzl +++ b/mediapipe/examples/ios/bundle_id.bzl @@ -15,7 +15,7 @@ """Configuration helper for iOS app bundle ids and provisioning profiles. """ -BUNDLE_ID_PREFIX = "*SEE_IOS_INSTRUCTIONS*.mediapipe.examples" +BUNDLE_ID_PREFIX = "a09f2333-1ef2-4378-b82d-658a2d248aa5.mediapipe.examples" # Look for a provisioning profile in the example's directory first, # otherwise look for a common one. diff --git a/mediapipe/examples/ios/posetrackingsolutiongpu/PoseTrackingViewController.mm b/mediapipe/examples/ios/posetrackingsolutiongpu/PoseTrackingViewController.mm index de49d7461..d3464db29 100644 --- a/mediapipe/examples/ios/posetrackingsolutiongpu/PoseTrackingViewController.mm +++ b/mediapipe/examples/ios/posetrackingsolutiongpu/PoseTrackingViewController.mm @@ -31,7 +31,7 @@ static const char* kLandmarksOutputStream = "pose_landmarks"; [super viewDidLoad]; // create pose tracking options - PoseTrackingOptions* options = [ [PoseTrackingOptions alloc] initWithShowLandmarks:true cameraRotation:0]; + PoseTrackingOptions* options = [ [PoseTrackingOptions alloc] initWithShowLandmarks:true]; // create pose tracking from options self.poseTracking = [[PoseTracking alloc] initWithPoseTrackingOptions:options]; // render pose tracking to a UIView (self.liveView) @@ -63,7 +63,14 @@ static const char* kLandmarksOutputStream = "pose_landmarks"; //self.cameraSource.videoMirrored = YES; // The frame's native format is rotated with respect to the portrait orientation. + // 0 degree self.cameraSource.orientation = AVCaptureVideoOrientationPortrait; + //90 degree +// self.cameraSource.orientation = AVCaptureVideoOrientationLandscapeRight; + //180 degree +// self.cameraSource.orientation = AVCaptureVideoOrientationPortraitUpsideDown; + //270 degree +// self.cameraSource.orientation = AVCaptureVideoOrientationLandscapeLeft; // request camera access permission [self.cameraSource requestCameraAccessWithCompletionHandler:^void(BOOL granted) { diff --git a/mediapipe/objc/solutions/posetracking_gpu/PoseTrackingOptions.h b/mediapipe/objc/solutions/posetracking_gpu/PoseTrackingOptions.h index 34a181097..40bbff0ae 100644 --- a/mediapipe/objc/solutions/posetracking_gpu/PoseTrackingOptions.h +++ b/mediapipe/objc/solutions/posetracking_gpu/PoseTrackingOptions.h @@ -8,9 +8,9 @@ @interface PoseTrackingOptions: NSObject @property(nonatomic) bool showLandmarks; -@property(nonatomic) int cameraRotation; +//@property(nonatomic) int cameraRotation; -- (instancetype) initWithShowLandmarks : (bool) showLandmarks cameraRotation:(int) cameraRotation; +- (instancetype) initWithShowLandmarks : (bool) showLandmarks; @end diff --git a/mediapipe/objc/solutions/posetracking_gpu/PoseTrackingOptions.mm b/mediapipe/objc/solutions/posetracking_gpu/PoseTrackingOptions.mm index 75a0444b6..f9c8911c3 100644 --- a/mediapipe/objc/solutions/posetracking_gpu/PoseTrackingOptions.mm +++ b/mediapipe/objc/solutions/posetracking_gpu/PoseTrackingOptions.mm @@ -2,8 +2,8 @@ @implementation PoseTrackingOptions -- (instancetype) initWithShowLandmarks : (bool) showLandmarks cameraRotation:(int) cameraRotation{ - self.cameraRotation = cameraRotation; +- (instancetype) initWithShowLandmarks : (bool) showLandmarks { +// self.cameraRotation = cameraRotation; self.showLandmarks = showLandmarks; return self; }