From 6253966901930f2bf45912330ae8098a34e1a733 Mon Sep 17 00:00:00 2001 From: Prianka Liz Kariat Date: Fri, 3 Mar 2023 12:15:25 +0530 Subject: [PATCH] Updated comments in MPPTaskRunner to include note about mirrored orientations --- .../ios/vision/core/sources/MPPVisionTaskRunner.h | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/mediapipe/tasks/ios/vision/core/sources/MPPVisionTaskRunner.h b/mediapipe/tasks/ios/vision/core/sources/MPPVisionTaskRunner.h index 007d4f648..ced188e3c 100644 --- a/mediapipe/tasks/ios/vision/core/sources/MPPVisionTaskRunner.h +++ b/mediapipe/tasks/ios/vision/core/sources/MPPVisionTaskRunner.h @@ -59,16 +59,23 @@ NS_ASSUME_NONNULL_BEGIN /** * Creates a `NormalizedRect` from a region of interest and an image orientation, performing - * sanity checks on-the-fly. If the input region of interest equals `CGRectZero`, returns a default - * `NormalizedRect` covering the whole image with rotation set according `imageOrientation`. If - * `roiAllowed` is NO, an error will be returned if the input region of interest is not equal to + * sanity checks on-the-fly. + * If the input region of interest equals `CGRectZero`, returns a default `NormalizedRect` covering + * the whole image with rotation set according `imageOrientation`. + * If `roiAllowed` is NO, an error will be returned if the input region of interest is not equal to * `CGRectZero`. + * Mirrored orientations (`UIImageOrientationUpMirrored`,`UIImageOrientationDownMirrored`, + * `UIImageOrientationLeftMirrored`,`UIImageOrientationRightMirrored`) are not supported. An error + * will be returned if `imageOrientation` is equal to any one of them. * * @param roi A `CGRect` specifying the region of interest. If the input region of interest equals * `CGRectZero`, the returned `NormalizedRect` covers the whole image. Make sure that `roi` equals * `CGRectZero` if `roiAllowed` is NO. Otherwise, an error will be returned. * @param imageOrientation A `UIImageOrientation` indicating the rotation to be applied to the * image. The resulting `NormalizedRect` will convert the `imageOrientation` to degrees clockwise. + * Mirrored orientations (`UIImageOrientationUpMirrored`, `UIImageOrientationDownMirrored`, + * `UIImageOrientationLeftMirrored`, `UIImageOrientationRightMirrored`) are not supported. An error + * will be returned if `imageOrientation` is equal to any one of them. * @param roiAllowed Indicates if the `roi` field is allowed to be a value other than `CGRectZero`. * @param error Pointer to the memory location where errors if any should be saved. If @c NULL, no * error will be saved.