cassdlcm/mediapipe
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Ensure that releaseGl() is called if prepapreGl throws

Browse Source 
Without this logic, we might have resources created within prepareGl() leaking, since they will never be released.

PiperOrigin-RevId: 583491569
This commit is contained in:
MediaPipe Team 2023-11-17 14:44:35 -08:00 committed by Copybara-Service
parent d29ea119ff
commit 42d42a5ea1
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
mediapipe/java/com/google/mediapipe/glutil/GlThread.java
View File

@ -128,6 +128,10 @@ public class GlThread extends Thread {
prepareGl(); prepareGl();
startedSuccessfully = true; startedSuccessfully = true;
} catch (RuntimeException e) {
releaseGl();
eglManager.release();
throw e;
} finally { } finally {
// Always stop waitUntilReady here, even if we got an exception. // Always stop waitUntilReady here, even if we got an exception.
// Otherwise the main thread may be stuck waiting. // Otherwise the main thread may be stuck waiting.