cassdlcm/mediapipe
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Use string_view when adding nodes/generators #cleanup

Browse Source 
PiperOrigin-RevId: 480721234
This commit is contained in:
MediaPipe Team 2022-10-12 14:40:26 -07:00 committed by Copybara-Service
parent 02746d0700
commit 179824a21d
1 changed files with 9 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
mediapipe/framework/api2/builder.h
View File

@ -440,8 +440,9 @@ class Graph {
// Creates a node of a specific type. Should be used for pure interfaces, // Creates a node of a specific type. Should be used for pure interfaces,
// which do not have a built-in type string. // which do not have a built-in type string.
template <class Calc> template <class Calc>
Node<Calc>& AddNode(const std::string& type) { Node<Calc>& AddNode(absl::string_view type) {
auto node = std::make_unique<Node<Calc>>(type); auto node =
std::make_unique<Node<Calc>>(std::string(type.data(), type.size()));
auto node_p = node.get(); auto node_p = node.get();
nodes_.emplace_back(std::move(node)); nodes_.emplace_back(std::move(node));
return *node_p; return *node_p;
@ -449,16 +450,18 @@ class Graph {
// Creates a generic node, with no compile-time checking of inputs and // Creates a generic node, with no compile-time checking of inputs and
// outputs. This can be used for calculators whose contract is not visible. // outputs. This can be used for calculators whose contract is not visible.
GenericNode& AddNode(const std::string& type) { GenericNode& AddNode(absl::string_view type) {
auto node = std::make_unique<GenericNode>(type); auto node =
std::make_unique<GenericNode>(std::string(type.data(), type.size()));
auto node_p = node.get(); auto node_p = node.get();
nodes_.emplace_back(std::move(node)); nodes_.emplace_back(std::move(node));
return *node_p; return *node_p;
} }
// For legacy PacketGenerators. // For legacy PacketGenerators.
PacketGenerator& AddPacketGenerator(const std::string& type) { PacketGenerator& AddPacketGenerator(absl::string_view type) {
auto node = std::make_unique<PacketGenerator>(type); auto node = std::make_unique<PacketGenerator>(
std::string(type.data(), type.size()));
auto node_p = node.get(); auto node_p = node.get();
packet_gens_.emplace_back(std::move(node)); packet_gens_.emplace_back(std::move(node));
return *node_p; return *node_p;