Merge pull request #4767 from priankakariatyml:ios-vision-task-refactoring-impl3

PiperOrigin-RevId: 563859728

mediapipe/tasks/ios/vision/core/BUILD

@@ -1,3 +1,17 @@
+# Copyright 2023 The MediaPipe Authors.
+#
+# Licensed under the Apache License, Version 2.0 (the "License");
+# you may not use this file except in compliance with the License.
+# You may obtain a copy of the License at
+#
+#      http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
 package(default_visibility = ["//mediapipe/tasks:internal"])
 
 licenses(["notice"])
@@ -52,27 +66,6 @@ objc_library(
         "-ObjC++",
         "-std=c++17",
     ],
-    deps = [
-        ":MPPRunningMode",
-        "//mediapipe/calculators/core:flow_limiter_calculator",
-        "//mediapipe/framework/formats:rect_cc_proto",
-        "//mediapipe/tasks/ios/common:MPPCommon",
-        "//mediapipe/tasks/ios/common/utils:MPPCommonUtils",
-        "//mediapipe/tasks/ios/common/utils:NSStringHelpers",
-        "//mediapipe/tasks/ios/core:MPPTaskRunner",
-        "//third_party/apple_frameworks:UIKit",
-        "@com_google_absl//absl/status:statusor",
-    ],
-)
-
-objc_library(
-    name = "MPPVisionTaskRunnerRefactored",
-    srcs = ["sources/MPPVisionTaskRunnerRefactored.mm"],
-    hdrs = ["sources/MPPVisionTaskRunnerRefactored.h"],
-    copts = [
-        "-ObjC++",
-        "-std=c++17",
-    ],
     deps = [
         ":MPPImage",
         ":MPPRunningMode",

mediapipe/tasks/ios/vision/core/sources/MPPVisionTaskRunner.h

@@ -15,11 +15,11 @@
 #import <Foundation/Foundation.h>
 #import <UIKit/UIKit.h>
 
+#import "mediapipe/tasks/ios/core/sources/MPPTaskInfo.h"
 #import "mediapipe/tasks/ios/core/sources/MPPTaskRunner.h"
+#import "mediapipe/tasks/ios/vision/core/sources/MPPImage.h"
 #import "mediapipe/tasks/ios/vision/core/sources/MPPRunningMode.h"
 
-#include "mediapipe/framework/formats/rect.pb.h"
-
 NS_ASSUME_NONNULL_BEGIN
 
 /**
@@ -29,112 +29,116 @@ NS_ASSUME_NONNULL_BEGIN
 @interface MPPVisionTaskRunner : MPPTaskRunner
 
 /**
- * Initializes a new `MPPVisionTaskRunner` with the MediaPipe calculator config proto running mode
+ * Initializes a new `MPPVisionTaskRunner` with the taskInfo, running mode, whether task supports
- * and packetsCallback.
+ * region of interest, packets callback, image and norm rect input stream names. Make sure that the
- * Make sure that the packets callback is set properly based on the vision task's running mode.
+ * packets callback is set properly based on the vision task's running mode. In case of live stream
- * In case of live stream running mode, a C++ packets callback that is intended to deliver inference
+ * running mode, a C++ packets callback that is intended to deliver inference results must be
- * results must be provided. In case of image or video running mode, packets callback must be set to
+ * provided. In case of image or video running mode, packets callback must be set to nil.
- * nil.
  *
- * @param graphConfig A MediaPipe calculator config proto.
+ * @param taskInfo A `MPPTaskInfo` initialized by the task.
  * @param runningMode MediaPipe vision task running mode.
+ * @param roiAllowed A `BOOL` indicating if the task supports region of interest.
  * @param packetsCallback An optional C++ callback function that takes a list of output packets as
  * the input argument. If provided, the callback must in turn call the block provided by the user in
  * the appropriate task options. Make sure that the packets callback is set properly based on the
  * vision task's running mode. In case of live stream running mode, a C++ packets callback that is
  * intended to deliver inference results must be provided. In case of image or video running mode,
  * packets callback must be set to nil.
+ * @param imageInputStreamName Name of the image input stream of the task.
+ * @param normRectInputStreamName Name of the norm rect input stream of the task.
  *
  * @param error Pointer to the memory location where errors if any should be saved. If @c NULL, no
  * error will be saved.
  *
- * @return An instance of `MPPVisionTaskRunner` initialized to the given MediaPipe calculator config
+ * @return An instance of `MPPVisionTaskRunner` initialized with the given the taskInfo, running
- * proto, running mode and packets callback.
+ * mode, whether task supports region of interest, packets callback, image and norm rect input
+ * stream names.
  */
-- (nullable instancetype)initWithCalculatorGraphConfig:(mediapipe::CalculatorGraphConfig)graphConfig
+
+- (nullable instancetype)initWithTaskInfo:(MPPTaskInfo *)taskInfo
                               runningMode:(MPPRunningMode)runningMode
-                                       packetsCallback:
+                               roiAllowed:(BOOL)roiAllowed
-                                           (mediapipe::tasks::core::PacketsCallback)packetsCallback
+                          packetsCallback:(mediapipe::tasks::core::PacketsCallback)packetsCallback
+                     imageInputStreamName:(NSString *)imageInputStreamName
+                  normRectInputStreamName:(NSString *)normRectInputStreamName
                                     error:(NSError **)error NS_DESIGNATED_INITIALIZER;
 
-/**
- * Creates a `NormalizedRect` from image orientation for a task which does not support roi,
- * performing sanity checks on-the-fly. Mirrored orientations
- * (`UIImageOrientationUpMirrored`,`UIImageOrientationDownMirrored`,
- * `UIImageOrientationLeftMirrored`,`UIImageOrientationRightMirrored`) are not supported. An error
- * will be returned if `imageOrientation` is equal to any one of them.
- *
- * @param imageOrientation A `UIImageOrientation` indicating the rotation to be applied to the
- * image. The resulting `NormalizedRect` will convert the `imageOrientation` to degrees clockwise.
- * Mirrored orientations (`UIImageOrientationUpMirrored`, `UIImageOrientationDownMirrored`,
- * `UIImageOrientationLeftMirrored`, `UIImageOrientationRightMirrored`) are not supported. An error
- * will be returned if `imageOrientation` is equal to any one of them.
- * @param imageSize A `CGSize` specifying the size of the image within which normalized rect is
- * calculated.
- * @param error Pointer to the memory location where errors if any should be saved. If @c NULL, no
- * error will be saved.
- *
- * @return An optional `NormalizedRect` from the given region of interest and image orientation.
- */
-- (std::optional<mediapipe::NormalizedRect>)normalizedRectWithImageOrientation:
-                                                (UIImageOrientation)imageOrientation
-                                                                     imageSize:(CGSize)imageSize
-                                                                         error:(NSError **)error;
-
-/**
- * Creates a `NormalizedRect` from roi and image orientation for a task which supports roi,
- * performing sanity checks on-the-fly. If the input region of interest equals `CGRectZero`, returns
- * a default `NormalizedRect` covering the whole image with rotation set according
- * `imageOrientation`. Mirrored orientations
- * (`UIImageOrientationUpMirrored`,`UIImageOrientationDownMirrored`,
- * `UIImageOrientationLeftMirrored`,`UIImageOrientationRightMirrored`) are not supported. An error
- * will be returned if `imageOrientation` is equal to any one of them.
- *
- * @param roi A `CGRect` specifying the region of interest. If the input region of interest equals
- * `CGRectZero`, the returned `NormalizedRect` covers the whole image.
- * @param imageOrientation A `UIImageOrientation` indicating the rotation to be applied to the
- * image. The resulting `NormalizedRect` will convert the `imageOrientation` to degrees clockwise.
- * Mirrored orientations (`UIImageOrientationUpMirrored`, `UIImageOrientationDownMirrored`,
- * `UIImageOrientationLeftMirrored`, `UIImageOrientationRightMirrored`) are not supported. An error
- * will be returned if `imageOrientation` is equal to any one of them.
- * @param imageSize A `CGSize` specifying the size of the image within which normalized rect is
- * calculated.
- * @param error Pointer to the memory location where errors if any should be saved. If @c NULL, no
- * error will be saved.
- *
- * @return An optional `NormalizedRect` from the given region of interest and image orientation.
- */
-- (std::optional<mediapipe::NormalizedRect>)
-    normalizedRectWithRegionOfInterest:(CGRect)roi
-                      imageOrientation:(UIImageOrientation)imageOrientation
-                             imageSize:(CGSize)imageSize
-                                 error:(NSError **)error;
 /**
  * A synchronous method to invoke the C++ task runner to process single image inputs. The call
  * blocks the current thread until a failure status or a successful result is returned.
  *
- * @param packetMap A `PacketMap` containing pairs of input stream name and data packet.
+ * This method must be used by tasks when region of interest must not be factored in for inference.
+ *
+ * @param image An `MPPImage` input to the task.
  * @param error Pointer to the memory location where errors if any should be
  * saved. If @c NULL, no error will be saved.
  *
  * @return An optional `PacketMap` containing pairs of output stream name and data packet.
  */
-- (std::optional<mediapipe::tasks::core::PacketMap>)
+- (std::optional<mediapipe::tasks::core::PacketMap>)processImage:(MPPImage *)image
-    processImagePacketMap:(const mediapipe::tasks::core::PacketMap &)packetMap
+                                                           error:(NSError **)error;
+
+/**
+ * A synchronous method to invoke the C++ task runner to process single image inputs. The call
+ * blocks the current thread until a failure status or a successful result is returned.
+ *
+ * This method must be used by tasks when region of interest must be factored in for inference.
+ * When tasks which do not support region of interest calls this method in combination with any roi
+ * other than `CGRectZero` an error is returned.
+ *
+ * @param image An `MPPImage` input to the task.
+ * @param regionOfInterest A `CGRect` specifying the region of interest within the given image data
+ * of type `MPPImage`, on which inference should be performed.
+ * @param error Pointer to the memory location where errors if any should be
+ * saved. If @c NULL, no error will be saved.
+ *
+ * @return An optional `PacketMap` containing pairs of output stream name and data packet.
+ */
+- (std::optional<mediapipe::tasks::core::PacketMap>)processImage:(MPPImage *)image
+                                                regionOfInterest:(CGRect)regionOfInterest
                                                            error:(NSError **)error;
 
 /**
  * A synchronous method to invoke the C++ task runner to process continuous video frames. The call
  * blocks the current thread until a failure status or a successful result is returned.
  *
- * @param packetMap A `PacketMap` containing pairs of input stream name and data packet.
+ * This method must be used by tasks when region of interest must not be factored in for inference.
+ *
+ * @param videoFrame An `MPPImage` input to the task.
+ * @param timestampInMilliseconds The video frame's timestamp (in milliseconds). The input
+ * timestamps must be monotonically increasing.
  * @param error Pointer to the memory location where errors if any should be saved. If @c NULL, no
  * error will be saved.
  *
  * @return An optional `PacketMap` containing pairs of output stream name and data packet.
  */
-- (std::optional<mediapipe::tasks::core::PacketMap>)
+- (std::optional<mediapipe::tasks::core::PacketMap>)processVideoFrame:(MPPImage *)videoFrame
-    processVideoFramePacketMap:(const mediapipe::tasks::core::PacketMap &)packetMap
+                                              timestampInMilliseconds:
+                                                  (NSInteger)timeStampInMilliseconds
+                                                                error:(NSError **)error;
+
+/**
+ * A synchronous method to invoke the C++ task runner to process continuous video frames. The call
+ * blocks the current thread until a failure status or a successful result is returned.
+ *
+ * This method must be used by tasks when region of interest must be factored in for inference.
+ * When tasks which do not support region of interest calls this method in combination with any roi
+ * other than `CGRectZero` an error is returned.
+ *
+ * @param videoFrame An `MPPImage` input to the task.
+ * @param timestampInMilliseconds The video frame's timestamp (in milliseconds). The input
+ * timestamps must be monotonically increasing.
+ * @param regionOfInterest A `CGRect` specifying the region of interest within the given image data
+ * of type `MPPImage`, on which inference should be performed.
+ * @param error Pointer to the memory location where errors if any should be saved. If @c NULL, no
+ * error will be saved.
+ *
+ * @return An optional `PacketMap` containing pairs of output stream name and data packet.
+ */
+- (std::optional<mediapipe::tasks::core::PacketMap>)processVideoFrame:(MPPImage *)videoFrame
+                                                     regionOfInterest:(CGRect)regionOfInterest
+                                              timestampInMilliseconds:
+                                                  (NSInteger)timeStampInMilliseconds
                                                                 error:(NSError **)error;
 
 /**
@@ -143,7 +147,11 @@ NS_ASSUME_NONNULL_BEGIN
  * available in the user-defined `packetsCallback` that was provided during initialization of the
  * `MPPVisionTaskRunner`.
  *
- * @param packetMap A `PacketMap` containing pairs of input stream name and data packet.
+ * This method must be used by tasks when region of interest must not be factored in for inference.
+ *
+ * @param image An `MPPImage` input to the task.
+ * @param timestampInMilliseconds The video frame's timestamp (in milliseconds). The input
+ * timestamps must be monotonically increasing.
  * @param error Pointer to the memory location where errors if any should be saved. If @c NULL, no
  * error will be saved.
  *
@@ -152,13 +160,35 @@ NS_ASSUME_NONNULL_BEGIN
  * available in the user-defined `packetsCallback` that was provided during initialization of the
  * `MPPVisionTaskRunner`.
  */
-- (BOOL)processLiveStreamPacketMap:(const mediapipe::tasks::core::PacketMap &)packetMap
+- (BOOL)processLiveStreamImage:(MPPImage *)image
+       timestampInMilliseconds:(NSInteger)timeStampInMilliseconds
                          error:(NSError **)error;
 
-- (instancetype)initWithCalculatorGraphConfig:(mediapipe::CalculatorGraphConfig)graphConfig
+/**
-                              packetsCallback:
+ * An asynchronous method to send live stream data to the C++ task runner. The call blocks the
-                                  (mediapipe::tasks::core::PacketsCallback)packetsCallback
+ * current thread until a failure status or a successful result is returned. The results will be
-                                        error:(NSError **)error NS_UNAVAILABLE;
+ * available in the user-defined `packetsCallback` that was provided during initialization of the
+ * `MPPVisionTaskRunner`.
+ *
+ * This method must be used by tasks when region of interest must not be factored in for inference.
+ *
+ * @param image An `MPPImage` input to the task.
+ * @param regionOfInterest A `CGRect` specifying the region of interest within the given image data
+ * of type `MPPImage`, on which inference should be performed.
+ * @param timestampInMilliseconds The video frame's timestamp (in milliseconds). The input
+ * timestamps must be monotonically increasing.
+ * @param error Pointer to the memory location where errors if any should be saved. If @c NULL, no
+ * error will be saved.
+ *
+ * @return A `BOOL` indicating if the live stream data was sent to the C++ task runner successfully.
+ * Please note that any errors during processing of the live stream packet map will only be
+ * available in the user-defined `packetsCallback` that was provided during initialization of the
+ * `MPPVisionTaskRunner`.
+ */
+- (BOOL)processLiveStreamImage:(MPPImage *)image
+              regionOfInterest:(CGRect)regionOfInterest
+       timestampInMilliseconds:(NSInteger)timeStampInMilliseconds
+                         error:(NSError **)error;
 
 /**
  * This method returns a unique dispatch queue name by adding the given suffix and a `UUID` to the
@@ -174,6 +204,11 @@ NS_ASSUME_NONNULL_BEGIN
  */
 + (const char *)uniqueDispatchQueueNameWithSuffix:(NSString *)suffix;
 
+- (instancetype)initWithCalculatorGraphConfig:(mediapipe::CalculatorGraphConfig)graphConfig
+                              packetsCallback:
+                                  (mediapipe::tasks::core::PacketsCallback)packetsCallback
+                                        error:(NSError **)error NS_UNAVAILABLE;
+
 - (instancetype)init NS_UNAVAILABLE;
 
 + (instancetype)new NS_UNAVAILABLE;

mediapipe/tasks/ios/vision/core/sources/MPPVisionTaskRunner.mm

@@ -17,14 +17,17 @@
 #import "mediapipe/tasks/ios/common/sources/MPPCommon.h"
 #import "mediapipe/tasks/ios/common/utils/sources/MPPCommonUtils.h"
 #import "mediapipe/tasks/ios/common/utils/sources/NSString+Helpers.h"
+#import "mediapipe/tasks/ios/core/sources/MPPTaskInfo.h"
+#import "mediapipe/tasks/ios/vision/core/sources/MPPVisionPacketCreator.h"
 
 #include "absl/status/statusor.h"
+#include "mediapipe/framework/formats/rect.pb.h"
 
 #include <optional>
 
 namespace {
-using ::mediapipe::CalculatorGraphConfig;
 using ::mediapipe::NormalizedRect;
+using ::mediapipe::Packet;
 using ::mediapipe::tasks::core::PacketMap;
 using ::mediapipe::tasks::core::PacketsCallback;
 }  // namespace
@@ -40,17 +43,32 @@ static const NSInteger kMPPOrientationDegreesLeft = -90;
 
 static NSString *const kTaskPrefix = @"com.mediapipe.tasks.vision";
 
+#define InputPacketMap(imagePacket, normalizedRectPacket)                              \
+  {                                                                                    \
+    {_imageInStreamName, imagePacket}, { _normRectInStreamName, normalizedRectPacket } \
+  }
+
 @interface MPPVisionTaskRunner () {
   MPPRunningMode _runningMode;
+  BOOL _roiAllowed;
+  std::string _imageInStreamName;
+  std::string _normRectInStreamName;
 }
 @end
 
 @implementation MPPVisionTaskRunner
 
-- (nullable instancetype)initWithCalculatorGraphConfig:(CalculatorGraphConfig)graphConfig
+- (nullable instancetype)initWithTaskInfo:(MPPTaskInfo *)taskInfo
                               runningMode:(MPPRunningMode)runningMode
+                               roiAllowed:(BOOL)roiAllowed
                           packetsCallback:(PacketsCallback)packetsCallback
+                     imageInputStreamName:(NSString *)imageInputStreamName
+                  normRectInputStreamName:(NSString *)normRectInputStreamName
                                     error:(NSError **)error {
+  _roiAllowed = roiAllowed;
+  _imageInStreamName = imageInputStreamName.cppString;
+  _normRectInStreamName = normRectInputStreamName.cppString;
+
   switch (runningMode) {
     case MPPRunningModeImage:
     case MPPRunningModeVideo: {
@@ -85,42 +103,18 @@ static NSString *const kTaskPrefix = @"com.mediapipe.tasks.vision";
   }
 
   _runningMode = runningMode;
-  self = [super initWithCalculatorGraphConfig:graphConfig
+  self = [super initWithCalculatorGraphConfig:[taskInfo generateGraphConfig]
                               packetsCallback:packetsCallback
                                         error:error];
   return self;
 }
 
-- (std::optional<NormalizedRect>)normalizedRectWithRegionOfInterest:(CGRect)roi
-                                                   imageOrientation:
-                                                       (UIImageOrientation)imageOrientation
-                                                          imageSize:(CGSize)imageSize
-                                                              error:(NSError **)error {
-  return [self normalizedRectWithRegionOfInterest:roi
-                                        imageSize:imageSize
-                                 imageOrientation:imageOrientation
-                                       ROIAllowed:YES
-                                            error:error];
-}
-
-- (std::optional<NormalizedRect>)normalizedRectWithImageOrientation:
-                                     (UIImageOrientation)imageOrientation
-                                                          imageSize:(CGSize)imageSize
-                                                              error:(NSError **)error {
-  return [self normalizedRectWithRegionOfInterest:CGRectZero
-                                        imageSize:imageSize
-                                 imageOrientation:imageOrientation
-                                       ROIAllowed:NO
-                                            error:error];
-}
-
 - (std::optional<NormalizedRect>)normalizedRectWithRegionOfInterest:(CGRect)roi
                                                           imageSize:(CGSize)imageSize
                                                    imageOrientation:
                                                        (UIImageOrientation)imageOrientation
-                                                         ROIAllowed:(BOOL)ROIAllowed
                                                               error:(NSError **)error {
-  if (!CGRectEqualToRect(roi, CGRectZero) && !ROIAllowed) {
+  if (!CGRectEqualToRect(roi, CGRectZero) && !_roiAllowed) {
     [MPPCommonUtils createCustomError:error
                              withCode:MPPTasksErrorCodeInvalidArgumentError
                           description:@"This task doesn't support region-of-interest."];
@@ -182,7 +176,60 @@ static NSString *const kTaskPrefix = @"com.mediapipe.tasks.vision";
   return normalizedRect;
 }
 
-- (std::optional<PacketMap>)processImagePacketMap:(const PacketMap &)packetMap
+- (std::optional<PacketMap>)inputPacketMapWithMPPImage:(MPPImage *)image
+                                      regionOfInterest:(CGRect)roi
+                                                 error:(NSError **)error {
+  std::optional<NormalizedRect> rect =
+      [self normalizedRectWithRegionOfInterest:roi
+                                     imageSize:CGSizeMake(image.width, image.height)
+                              imageOrientation:image.orientation
+                                         error:error];
+  if (!rect.has_value()) {
+    return std::nullopt;
+  }
+
+  Packet imagePacket = [MPPVisionPacketCreator createPacketWithMPPImage:image error:error];
+  if (imagePacket.IsEmpty()) {
+    return std::nullopt;
+  }
+
+  Packet normalizedRectPacket =
+      [MPPVisionPacketCreator createPacketWithNormalizedRect:rect.value()];
+
+  PacketMap inputPacketMap = InputPacketMap(imagePacket, normalizedRectPacket);
+  return inputPacketMap;
+}
+
+- (std::optional<PacketMap>)inputPacketMapWithMPPImage:(MPPImage *)image
+                                      regionOfInterest:(CGRect)roi
+                               timestampInMilliseconds:(NSInteger)timestampInMilliseconds
+                                                 error:(NSError **)error {
+  std::optional<NormalizedRect> rect =
+      [self normalizedRectWithRegionOfInterest:roi
+                                     imageSize:CGSizeMake(image.width, image.height)
+                              imageOrientation:image.orientation
+                                         error:error];
+  if (!rect.has_value()) {
+    return std::nullopt;
+  }
+
+  Packet imagePacket = [MPPVisionPacketCreator createPacketWithMPPImage:image
+                                                timestampInMilliseconds:timestampInMilliseconds
+                                                                  error:error];
+  if (imagePacket.IsEmpty()) {
+    return std::nullopt;
+  }
+
+  Packet normalizedRectPacket =
+      [MPPVisionPacketCreator createPacketWithNormalizedRect:rect.value()
+                                     timestampInMilliseconds:timestampInMilliseconds];
+
+  PacketMap inputPacketMap = InputPacketMap(imagePacket, normalizedRectPacket);
+  return inputPacketMap;
+}
+
+- (std::optional<PacketMap>)processImage:(MPPImage *)image
+                        regionOfInterest:(CGRect)regionOfInterest
                                    error:(NSError **)error {
   if (_runningMode != MPPRunningModeImage) {
     [MPPCommonUtils
@@ -194,10 +241,23 @@ static NSString *const kTaskPrefix = @"com.mediapipe.tasks.vision";
     return std::nullopt;
   }
 
-  return [self processPacketMap:packetMap error:error];
+  std::optional<PacketMap> inputPacketMap = [self inputPacketMapWithMPPImage:image
+                                                            regionOfInterest:regionOfInterest
+                                                                       error:error];
+  if (!inputPacketMap.has_value()) {
+    return std::nullopt;
+  }
+
+  return [self processPacketMap:inputPacketMap.value() error:error];
 }
 
-- (std::optional<PacketMap>)processVideoFramePacketMap:(const PacketMap &)packetMap
+- (std::optional<PacketMap>)processImage:(MPPImage *)image error:(NSError **)error {
+  return [self processImage:image regionOfInterest:CGRectZero error:error];
+}
+
+- (std::optional<PacketMap>)processVideoFrame:(MPPImage *)videoFrame
+                             regionOfInterest:(CGRect)regionOfInterest
+                      timestampInMilliseconds:(NSInteger)timestampInMilliseconds
                                         error:(NSError **)error {
   if (_runningMode != MPPRunningModeVideo) {
     [MPPCommonUtils
@@ -209,10 +269,30 @@ static NSString *const kTaskPrefix = @"com.mediapipe.tasks.vision";
     return std::nullopt;
   }
 
-  return [self processPacketMap:packetMap error:error];
+  std::optional<PacketMap> inputPacketMap = [self inputPacketMapWithMPPImage:videoFrame
+                                                            regionOfInterest:regionOfInterest
+                                                     timestampInMilliseconds:timestampInMilliseconds
+                                                                       error:error];
+  if (!inputPacketMap.has_value()) {
+    return std::nullopt;
+  }
+
+  return [self processPacketMap:inputPacketMap.value() error:error];
 }
 
-- (BOOL)processLiveStreamPacketMap:(const PacketMap &)packetMap error:(NSError **)error {
+- (std::optional<PacketMap>)processVideoFrame:(MPPImage *)videoFrame
+                      timestampInMilliseconds:(NSInteger)timestampInMilliseconds
+                                        error:(NSError **)error {
+  return [self processVideoFrame:videoFrame
+                regionOfInterest:CGRectZero
+         timestampInMilliseconds:timestampInMilliseconds
+                           error:error];
+}
+
+- (BOOL)processLiveStreamImage:(MPPImage *)image
+              regionOfInterest:(CGRect)regionOfInterest
+       timestampInMilliseconds:(NSInteger)timestampInMilliseconds
+                         error:(NSError **)error {
   if (_runningMode != MPPRunningModeLiveStream) {
     [MPPCommonUtils
         createCustomError:error
@@ -223,7 +303,24 @@ static NSString *const kTaskPrefix = @"com.mediapipe.tasks.vision";
     return NO;
   }
 
-  return [self sendPacketMap:packetMap error:error];
+  std::optional<PacketMap> inputPacketMap = [self inputPacketMapWithMPPImage:image
+                                                            regionOfInterest:regionOfInterest
+                                                     timestampInMilliseconds:timestampInMilliseconds
+                                                                       error:error];
+  if (!inputPacketMap.has_value()) {
+    return NO;
+  }
+
+  return [self sendPacketMap:inputPacketMap.value() error:error];
+}
+
+- (BOOL)processLiveStreamImage:(MPPImage *)image
+       timestampInMilliseconds:(NSInteger)timestampInMilliseconds
+                         error:(NSError **)error {
+  return [self processLiveStreamImage:image
+                     regionOfInterest:CGRectZero
+              timestampInMilliseconds:timestampInMilliseconds
+                                error:error];
 }
 
 + (const char *)uniqueDispatchQueueNameWithSuffix:(NSString *)suffix {

mediapipe/tasks/ios/vision/core/sources/MPPVisionTaskRunnerRefactored.h

@@ -1,218 +0,0 @@
-// Copyright 2023 The MediaPipe Authors.
-//
-// Licensed under the Apache License, Version 2.0 (the "License");
-// you may not use this file except in compliance with the License.
-// You may obtain a copy of the License at
-//
-//      http://www.apache.org/licenses/LICENSE-2.0
-//
-// Unless required by applicable law or agreed to in writing, software
-// distributed under the License is distributed on an "AS IS" BASIS,
-// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-// See the License for the specific language governing permissions and
-// limitations under the License.
-
-#import <Foundation/Foundation.h>
-#import <UIKit/UIKit.h>
-
-#import "mediapipe/tasks/ios/core/sources/MPPTaskInfo.h"
-#import "mediapipe/tasks/ios/core/sources/MPPTaskRunner.h"
-#import "mediapipe/tasks/ios/vision/core/sources/MPPImage.h"
-#import "mediapipe/tasks/ios/vision/core/sources/MPPRunningMode.h"
-
-NS_ASSUME_NONNULL_BEGIN
-
-/**
- * This class is used to create and call appropriate methods on the C++ Task Runner to initialize,
- * execute and terminate any MediaPipe vision task.
- */
-@interface MPPVisionTaskRunner : MPPTaskRunner
-
-/**
- * Initializes a new `MPPVisionTaskRunner` with the taskInfo, running mode, whether task supports
- * region of interest, packets callback, image and norm rect input stream names. Make sure that the
- * packets callback is set properly based on the vision task's running mode. In case of live stream
- * running mode, a C++ packets callback that is intended to deliver inference results must be
- * provided. In case of image or video running mode, packets callback must be set to nil.
- *
- * @param taskInfo A `MPPTaskInfo` initialized by the task.
- * @param runningMode MediaPipe vision task running mode.
- * @param roiAllowed A `BOOL` indicating if the task supports region of interest.
- * @param packetsCallback An optional C++ callback function that takes a list of output packets as
- * the input argument. If provided, the callback must in turn call the block provided by the user in
- * the appropriate task options. Make sure that the packets callback is set properly based on the
- * vision task's running mode. In case of live stream running mode, a C++ packets callback that is
- * intended to deliver inference results must be provided. In case of image or video running mode,
- * packets callback must be set to nil.
- * @param imageInputStreamName Name of the image input stream of the task.
- * @param normRectInputStreamName Name of the norm rect input stream of the task.
- *
- * @param error Pointer to the memory location where errors if any should be saved. If @c NULL, no
- * error will be saved.
- *
- * @return An instance of `MPPVisionTaskRunner` initialized with the given the taskInfo, running
- * mode, whether task supports region of interest, packets callback, image and norm rect input
- * stream names.
- */
-
-- (nullable instancetype)initWithTaskInfo:(MPPTaskInfo *)taskInfo
-                              runningMode:(MPPRunningMode)runningMode
-                               roiAllowed:(BOOL)roiAllowed
-                          packetsCallback:(mediapipe::tasks::core::PacketsCallback)packetsCallback
-                     imageInputStreamName:(NSString *)imageInputStreamName
-                  normRectInputStreamName:(NSString *)normRectInputStreamName
-                                    error:(NSError **)error NS_DESIGNATED_INITIALIZER;
-
-/**
- * A synchronous method to invoke the C++ task runner to process single image inputs. The call
- * blocks the current thread until a failure status or a successful result is returned.
- *
- * This method must be used by tasks when region of interest must not be factored in for inference.
- *
- * @param image An `MPPImage` input to the task.
- * @param error Pointer to the memory location where errors if any should be
- * saved. If @c NULL, no error will be saved.
- *
- * @return An optional `PacketMap` containing pairs of output stream name and data packet.
- */
-- (std::optional<mediapipe::tasks::core::PacketMap>)processImage:(MPPImage *)image
-                                                           error:(NSError **)error;
-
-/**
- * A synchronous method to invoke the C++ task runner to process single image inputs. The call
- * blocks the current thread until a failure status or a successful result is returned.
- *
- * This method must be used by tasks when region of interest must be factored in for inference.
- * When tasks which do not support region of interest calls this method in combination with any roi
- * other than `CGRectZero` an error is returned.
- *
- * @param image An `MPPImage` input to the task.
- * @param regionOfInterest A `CGRect` specifying the region of interest within the given image data
- * of type `MPPImage`, on which inference should be performed.
- * @param error Pointer to the memory location where errors if any should be
- * saved. If @c NULL, no error will be saved.
- *
- * @return An optional `PacketMap` containing pairs of output stream name and data packet.
- */
-- (std::optional<mediapipe::tasks::core::PacketMap>)processImage:(MPPImage *)image
-                                                regionOfInterest:(CGRect)regionOfInterest
-                                                           error:(NSError **)error;
-
-/**
- * A synchronous method to invoke the C++ task runner to process continuous video frames. The call
- * blocks the current thread until a failure status or a successful result is returned.
- *
- * This method must be used by tasks when region of interest must not be factored in for inference.
- *
- * @param videoFrame An `MPPImage` input to the task.
- * @param timestampInMilliseconds The video frame's timestamp (in milliseconds). The input
- * timestamps must be monotonically increasing.
- * @param error Pointer to the memory location where errors if any should be saved. If @c NULL, no
- * error will be saved.
- *
- * @return An optional `PacketMap` containing pairs of output stream name and data packet.
- */
-- (std::optional<mediapipe::tasks::core::PacketMap>)processVideoFrame:(MPPImage *)videoFrame
-                                              timestampInMilliseconds:
-                                                  (NSInteger)timeStampInMilliseconds
-                                                                error:(NSError **)error;
-
-/**
- * A synchronous method to invoke the C++ task runner to process continuous video frames. The call
- * blocks the current thread until a failure status or a successful result is returned.
- *
- * This method must be used by tasks when region of interest must be factored in for inference.
- * When tasks which do not support region of interest calls this method in combination with any roi
- * other than `CGRectZero` an error is returned.
- *
- * @param videoFrame An `MPPImage` input to the task.
- * @param timestampInMilliseconds The video frame's timestamp (in milliseconds). The input
- * timestamps must be monotonically increasing.
- * @param regionOfInterest A `CGRect` specifying the region of interest within the given image data
- * of type `MPPImage`, on which inference should be performed.
- * @param error Pointer to the memory location where errors if any should be saved. If @c NULL, no
- * error will be saved.
- *
- * @return An optional `PacketMap` containing pairs of output stream name and data packet.
- */
-- (std::optional<mediapipe::tasks::core::PacketMap>)processVideoFrame:(MPPImage *)videoFrame
-                                                     regionOfInterest:(CGRect)regionOfInterest
-                                              timestampInMilliseconds:
-                                                  (NSInteger)timeStampInMilliseconds
-                                                                error:(NSError **)error;
-
-/**
- * An asynchronous method to send live stream data to the C++ task runner. The call blocks the
- * current thread until a failure status or a successful result is returned. The results will be
- * available in the user-defined `packetsCallback` that was provided during initialization of the
- * `MPPVisionTaskRunner`.
- *
- * This method must be used by tasks when region of interest must not be factored in for inference.
- *
- * @param image An `MPPImage` input to the task.
- * @param timestampInMilliseconds The video frame's timestamp (in milliseconds). The input
- * timestamps must be monotonically increasing.
- * @param error Pointer to the memory location where errors if any should be saved. If @c NULL, no
- * error will be saved.
- *
- * @return A `BOOL` indicating if the live stream data was sent to the C++ task runner successfully.
- * Please note that any errors during processing of the live stream packet map will only be
- * available in the user-defined `packetsCallback` that was provided during initialization of the
- * `MPPVisionTaskRunner`.
- */
-- (BOOL)processLiveStreamImage:(MPPImage *)image
-       timestampInMilliseconds:(NSInteger)timeStampInMilliseconds
-                         error:(NSError **)error;
-
-/**
- * An asynchronous method to send live stream data to the C++ task runner. The call blocks the
- * current thread until a failure status or a successful result is returned. The results will be
- * available in the user-defined `packetsCallback` that was provided during initialization of the
- * `MPPVisionTaskRunner`.
- *
- * This method must be used by tasks when region of interest must not be factored in for inference.
- *
- * @param image An `MPPImage` input to the task.
- * @param regionOfInterest A `CGRect` specifying the region of interest within the given image data
- * of type `MPPImage`, on which inference should be performed.
- * @param timestampInMilliseconds The video frame's timestamp (in milliseconds). The input
- * timestamps must be monotonically increasing.
- * @param error Pointer to the memory location where errors if any should be saved. If @c NULL, no
- * error will be saved.
- *
- * @return A `BOOL` indicating if the live stream data was sent to the C++ task runner successfully.
- * Please note that any errors during processing of the live stream packet map will only be
- * available in the user-defined `packetsCallback` that was provided during initialization of the
- * `MPPVisionTaskRunner`.
- */
-- (BOOL)processLiveStreamImage:(MPPImage *)image
-              regionOfInterest:(CGRect)regionOfInterest
-       timestampInMilliseconds:(NSInteger)timeStampInMilliseconds
-                         error:(NSError **)error;
-
-/**
- * This method returns a unique dispatch queue name by adding the given suffix and a `UUID` to the
- * pre-defined queue name prefix for vision tasks. The vision tasks can use this method to get
- * unique dispatch queue names which are consistent with other vision tasks.
- * Dispatch queue names need not be unique, but for easy debugging we ensure that the queue names
- * are unique.
- *
- * @param suffix A suffix that identifies a dispatch queue's functionality.
- *
- * @return A unique dispatch queue name by adding the given suffix and a `UUID` to the pre-defined
- * queue name prefix for vision tasks.
- */
-+ (const char *)uniqueDispatchQueueNameWithSuffix:(NSString *)suffix;
-
-- (instancetype)initWithCalculatorGraphConfig:(mediapipe::CalculatorGraphConfig)graphConfig
-                              packetsCallback:
-                                  (mediapipe::tasks::core::PacketsCallback)packetsCallback
-                                        error:(NSError **)error NS_UNAVAILABLE;
-
-- (instancetype)init NS_UNAVAILABLE;
-
-+ (instancetype)new NS_UNAVAILABLE;
-
-@end
-
-NS_ASSUME_NONNULL_END

mediapipe/tasks/ios/vision/core/sources/MPPVisionTaskRunnerRefactored.mm

@@ -1,331 +0,0 @@
-// Copyright 2023 The MediaPipe Authors.
-//
-// Licensed under the Apache License, Version 2.0 (the "License");
-// you may not use this file except in compliance with the License.
-// You may obtain a copy of the License at
-//
-//      http://www.apache.org/licenses/LICENSE-2.0
-//
-// Unless required by applicable law or agreed to in writing, software
-// distributed under the License is distributed on an "AS IS" BASIS,
-// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-// See the License for the specific language governing permissions and
-// limitations under the License.
-
-#import "mediapipe/tasks/ios/vision/core/sources/MPPVisionTaskRunnerRefactored.h"
-
-#import "mediapipe/tasks/ios/common/sources/MPPCommon.h"
-#import "mediapipe/tasks/ios/common/utils/sources/MPPCommonUtils.h"
-#import "mediapipe/tasks/ios/common/utils/sources/NSString+Helpers.h"
-#import "mediapipe/tasks/ios/core/sources/MPPTaskInfo.h"
-#import "mediapipe/tasks/ios/vision/core/sources/MPPVisionPacketCreator.h"
-
-#include "absl/status/statusor.h"
-#include "mediapipe/framework/formats/rect.pb.h"
-
-#include <optional>
-
-namespace {
-using ::mediapipe::NormalizedRect;
-using ::mediapipe::Packet;
-using ::mediapipe::tasks::core::PacketMap;
-using ::mediapipe::tasks::core::PacketsCallback;
-}  // namespace
-
-/** Rotation degrees for a 90 degree rotation to the right. */
-static const NSInteger kMPPOrientationDegreesRight = -270;
-
-/** Rotation degrees for a 180 degree rotation. */
-static const NSInteger kMPPOrientationDegreesDown = -180;
-
-/** Rotation degrees for a 90 degree rotation to the left. */
-static const NSInteger kMPPOrientationDegreesLeft = -90;
-
-static NSString *const kTaskPrefix = @"com.mediapipe.tasks.vision";
-
-#define InputPacketMap(imagePacket, normalizedRectPacket)                              \
-  {                                                                                    \
-    {_imageInStreamName, imagePacket}, { _normRectInStreamName, normalizedRectPacket } \
-  }
-
-@interface MPPVisionTaskRunner () {
-  MPPRunningMode _runningMode;
-  BOOL _roiAllowed;
-  std::string _imageInStreamName;
-  std::string _normRectInStreamName;
-}
-@end
-
-@implementation MPPVisionTaskRunner
-
-- (nullable instancetype)initWithTaskInfo:(MPPTaskInfo *)taskInfo
-                              runningMode:(MPPRunningMode)runningMode
-                               roiAllowed:(BOOL)roiAllowed
-                          packetsCallback:(PacketsCallback)packetsCallback
-                     imageInputStreamName:(NSString *)imageInputStreamName
-                  normRectInputStreamName:(NSString *)normRectInputStreamName
-                                    error:(NSError **)error {
-  _roiAllowed = roiAllowed;
-  _imageInStreamName = imageInputStreamName.cppString;
-  _normRectInStreamName = normRectInputStreamName.cppString;
-
-  switch (runningMode) {
-    case MPPRunningModeImage:
-    case MPPRunningModeVideo: {
-      if (packetsCallback) {
-        [MPPCommonUtils createCustomError:error
-                                 withCode:MPPTasksErrorCodeInvalidArgumentError
-                              description:@"The vision task is in image or video mode. The "
-                                          @"delegate must not be set in the task's options."];
-        return nil;
-      }
-      break;
-    }
-    case MPPRunningModeLiveStream: {
-      if (!packetsCallback) {
-        [MPPCommonUtils
-            createCustomError:error
-                     withCode:MPPTasksErrorCodeInvalidArgumentError
-                  description:
-                      @"The vision task is in live stream mode. An object must be set as the "
-                      @"delegate of the task in its options to ensure asynchronous delivery of "
-                      @"results."];
-        return nil;
-      }
-      break;
-    }
-    default: {
-      [MPPCommonUtils createCustomError:error
-                               withCode:MPPTasksErrorCodeInvalidArgumentError
-                            description:@"Unrecognized running mode"];
-      return nil;
-    }
-  }
-
-  _runningMode = runningMode;
-  self = [super initWithCalculatorGraphConfig: [taskInfo generateGraphConfig]
-                              packetsCallback:packetsCallback
-                                        error:error];
-  return self;
-}
-
-- (std::optional<NormalizedRect>)normalizedRectWithRegionOfInterest:(CGRect)roi
-                                                          imageSize:(CGSize)imageSize
-                                                   imageOrientation:
-                                                       (UIImageOrientation)imageOrientation
-                                                              error:(NSError **)error {
-  if (!CGRectEqualToRect(roi, CGRectZero) && !_roiAllowed) {
-    [MPPCommonUtils createCustomError:error
-                             withCode:MPPTasksErrorCodeInvalidArgumentError
-                          description:@"This task doesn't support region-of-interest."];
-    return std::nullopt;
-  }
-
-  CGRect calculatedRoi = CGRectEqualToRect(roi, CGRectZero) ? CGRectMake(0.0, 0.0, 1.0, 1.0) : roi;
-
-  NormalizedRect normalizedRect;
-  normalizedRect.set_x_center(CGRectGetMidX(calculatedRoi));
-  normalizedRect.set_y_center(CGRectGetMidY(calculatedRoi));
-
-  int rotationDegrees = 0;
-  switch (imageOrientation) {
-    case UIImageOrientationUp:
-      break;
-    case UIImageOrientationRight: {
-      rotationDegrees = kMPPOrientationDegreesRight;
-      break;
-    }
-    case UIImageOrientationDown: {
-      rotationDegrees = kMPPOrientationDegreesDown;
-      break;
-    }
-    case UIImageOrientationLeft: {
-      rotationDegrees = kMPPOrientationDegreesLeft;
-      break;
-    }
-    default:
-      [MPPCommonUtils
-          createCustomError:error
-                   withCode:MPPTasksErrorCodeInvalidArgumentError
-                description:
-                    @"Unsupported UIImageOrientation. `imageOrientation` cannot be equal to "
-                    @"any of the mirrored orientations "
-                    @"(`UIImageOrientationUpMirrored`,`UIImageOrientationDownMirrored`,`"
-                    @"UIImageOrientationLeftMirrored`,`UIImageOrientationRightMirrored`)"];
-  }
-
-  normalizedRect.set_rotation(rotationDegrees * M_PI / kMPPOrientationDegreesDown);
-
-  // For 90° and 270° rotations, we need to swap width and height.
-  // This is due to the internal behavior of ImageToTensorCalculator, which:
-  // - first denormalizes the provided rect by multiplying the rect width or height by the image
-  //   width or height, respectively.
-  // - then rotates this by denormalized rect by the provided rotation, and uses this for cropping,
-  // - then finally rotates this back.
-  if (rotationDegrees % 180 == 0) {
-    normalizedRect.set_width(CGRectGetWidth(calculatedRoi));
-    normalizedRect.set_height(CGRectGetHeight(calculatedRoi));
-  } else {
-    const float width = CGRectGetHeight(calculatedRoi) * imageSize.height / imageSize.width;
-    const float height = CGRectGetWidth(calculatedRoi) * imageSize.width / imageSize.height;
-
-    normalizedRect.set_width(width);
-    normalizedRect.set_height(height);
-  }
-
-  return normalizedRect;
-}
-
-- (std::optional<PacketMap>)inputPacketMapWithMPPImage:(MPPImage *)image
-                                      regionOfInterest:(CGRect)roi
-                                                 error:(NSError **)error {
-  std::optional<NormalizedRect> rect =
-      [self normalizedRectWithRegionOfInterest:roi
-                                     imageSize:CGSizeMake(image.width, image.height)
-                              imageOrientation:image.orientation
-                                         error:error];
-  if (!rect.has_value()) {
-    return std::nullopt;
-  }
-
-  Packet imagePacket = [MPPVisionPacketCreator createPacketWithMPPImage:image error:error];
-  if (imagePacket.IsEmpty()) {
-    return std::nullopt;
-  }
-
-  Packet normalizedRectPacket =
-      [MPPVisionPacketCreator createPacketWithNormalizedRect:rect.value()];
-
-  PacketMap inputPacketMap = InputPacketMap(imagePacket, normalizedRectPacket);
-  return inputPacketMap;
-}
-
-- (std::optional<PacketMap>)inputPacketMapWithMPPImage:(MPPImage *)image
-                                      regionOfInterest:(CGRect)roi
-                               timestampInMilliseconds:(NSInteger)timestampInMilliseconds
-                                                 error:(NSError **)error {
-  std::optional<NormalizedRect> rect =
-      [self normalizedRectWithRegionOfInterest:roi
-                                     imageSize:CGSizeMake(image.width, image.height)
-                              imageOrientation:image.orientation
-                                         error:error];
-  if (!rect.has_value()) {
-    return std::nullopt;
-  }
-
-  Packet imagePacket = [MPPVisionPacketCreator createPacketWithMPPImage:image
-                                                timestampInMilliseconds:timestampInMilliseconds
-                                                                  error:error];
-  if (imagePacket.IsEmpty()) {
-    return std::nullopt;
-  }
-
-  Packet normalizedRectPacket =
-      [MPPVisionPacketCreator createPacketWithNormalizedRect:rect.value()
-                                     timestampInMilliseconds:timestampInMilliseconds];
-
-  PacketMap inputPacketMap = InputPacketMap(imagePacket, normalizedRectPacket);
-  return inputPacketMap;
-}
-
-- (std::optional<PacketMap>)processImage:(MPPImage *)image
-                        regionOfInterest:(CGRect)regionOfInterest
-                                   error:(NSError **)error {
-  if (_runningMode != MPPRunningModeImage) {
-    [MPPCommonUtils
-        createCustomError:error
-                 withCode:MPPTasksErrorCodeInvalidArgumentError
-              description:[NSString stringWithFormat:@"The vision task is not initialized with "
-                                                     @"image mode. Current Running Mode: %@",
-                                                     MPPRunningModeDisplayName(_runningMode)]];
-    return std::nullopt;
-  }
-
-  std::optional<PacketMap> inputPacketMap = [self inputPacketMapWithMPPImage:image
-                                                            regionOfInterest:regionOfInterest
-                                                                       error:error];
-  if (!inputPacketMap.has_value()) {
-    return std::nullopt;
-  }
-
-  return [self processPacketMap:inputPacketMap.value() error:error];
-}
-
-- (std::optional<PacketMap>)processImage:(MPPImage *)image error:(NSError **)error {
-  return [self processImage:image regionOfInterest:CGRectZero error:error];
-}
-
-- (std::optional<PacketMap>)processVideoFrame:(MPPImage *)videoFrame
-                             regionOfInterest:(CGRect)regionOfInterest
-                      timestampInMilliseconds:(NSInteger)timestampInMilliseconds
-                                        error:(NSError **)error {
-  if (_runningMode != MPPRunningModeVideo) {
-    [MPPCommonUtils
-        createCustomError:error
-                 withCode:MPPTasksErrorCodeInvalidArgumentError
-              description:[NSString stringWithFormat:@"The vision task is not initialized with "
-                                                     @"video mode. Current Running Mode: %@",
-                                                     MPPRunningModeDisplayName(_runningMode)]];
-    return std::nullopt;
-  }
-
-  std::optional<PacketMap> inputPacketMap = [self inputPacketMapWithMPPImage:videoFrame
-                                                            regionOfInterest:regionOfInterest
-                                                     timestampInMilliseconds:timestampInMilliseconds
-                                                                       error:error];
-  if (!inputPacketMap.has_value()) {
-    return std::nullopt;
-  }
-
-  return [self processPacketMap:inputPacketMap.value() error:error];
-}
-
-- (std::optional<PacketMap>)processVideoFrame:(MPPImage *)videoFrame
-                      timestampInMilliseconds:(NSInteger)timestampInMilliseconds
-                                        error:(NSError **)error {
-  return [self processVideoFrame:videoFrame
-                regionOfInterest:CGRectZero
-         timestampInMilliseconds:timestampInMilliseconds
-                           error:error];
-}
-
-- (BOOL)processLiveStreamImage:(MPPImage *)image
-              regionOfInterest:(CGRect)regionOfInterest
-       timestampInMilliseconds:(NSInteger)timestampInMilliseconds
-                         error:(NSError **)error {
-  if (_runningMode != MPPRunningModeLiveStream) {
-    [MPPCommonUtils
-        createCustomError:error
-                 withCode:MPPTasksErrorCodeInvalidArgumentError
-              description:[NSString stringWithFormat:@"The vision task is not initialized with "
-                                                     @"live stream mode. Current Running Mode: %@",
-                                                     MPPRunningModeDisplayName(_runningMode)]];
-    return NO;
-  }
-
-  std::optional<PacketMap> inputPacketMap = [self inputPacketMapWithMPPImage:image
-                                                            regionOfInterest:regionOfInterest
-                                                     timestampInMilliseconds:timestampInMilliseconds
-                                                                       error:error];
-  if (!inputPacketMap.has_value()) {
-    return NO;
-  }
-
-  return [self sendPacketMap:inputPacketMap.value() error:error];
-}
-
-- (BOOL)processLiveStreamImage:(MPPImage *)image
-       timestampInMilliseconds:(NSInteger)timestampInMilliseconds
-                         error:(NSError **)error {
-  return [self processLiveStreamImage:image
-                     regionOfInterest:CGRectZero
-              timestampInMilliseconds:timestampInMilliseconds
-                                error:error];
-}
-
-+ (const char *)uniqueDispatchQueueNameWithSuffix:(NSString *)suffix {
-  return [NSString stringWithFormat:@"%@.%@_%@", kTaskPrefix, suffix, [NSString uuidString]]
-      .UTF8String;
-}
-
-@end

mediapipe/tasks/ios/vision/face_detector/BUILD

@@ -55,7 +55,7 @@ objc_library(
         "//mediapipe/tasks/ios/core:MPPTaskInfo",
         "//mediapipe/tasks/ios/vision/core:MPPImage",
         "//mediapipe/tasks/ios/vision/core:MPPVisionPacketCreator",
-        "//mediapipe/tasks/ios/vision/core:MPPVisionTaskRunnerRefactored",
+        "//mediapipe/tasks/ios/vision/core:MPPVisionTaskRunner",
         "//mediapipe/tasks/ios/vision/face_detector/utils:MPPFaceDetectorOptionsHelpers",
         "//mediapipe/tasks/ios/vision/face_detector/utils:MPPFaceDetectorResultHelpers",
     ],

mediapipe/tasks/ios/vision/face_detector/sources/MPPFaceDetector.mm

@@ -18,7 +18,7 @@
 #import "mediapipe/tasks/ios/common/utils/sources/NSString+Helpers.h"
 #import "mediapipe/tasks/ios/core/sources/MPPTaskInfo.h"
 #import "mediapipe/tasks/ios/vision/core/sources/MPPVisionPacketCreator.h"
-#import "mediapipe/tasks/ios/vision/core/sources/MPPVisionTaskRunnerRefactored.h"
+#import "mediapipe/tasks/ios/vision/core/sources/MPPVisionTaskRunner.h"
 #import "mediapipe/tasks/ios/vision/face_detector/utils/sources/MPPFaceDetectorOptions+Helpers.h"
 #import "mediapipe/tasks/ios/vision/face_detector/utils/sources/MPPFaceDetectorResult+Helpers.h"
 

mediapipe/tasks/ios/vision/face_landmarker/BUILD

@@ -70,7 +70,7 @@ objc_library(
         "//mediapipe/tasks/ios/core:MPPTaskInfo",
         "//mediapipe/tasks/ios/vision/core:MPPImage",
         "//mediapipe/tasks/ios/vision/core:MPPVisionPacketCreator",
-        "//mediapipe/tasks/ios/vision/core:MPPVisionTaskRunnerRefactored",
+        "//mediapipe/tasks/ios/vision/core:MPPVisionTaskRunner",
         "//mediapipe/tasks/ios/vision/face_landmarker/utils:MPPFaceLandmarkerOptionsHelpers",
         "//mediapipe/tasks/ios/vision/face_landmarker/utils:MPPFaceLandmarkerResultHelpers",
     ],

mediapipe/tasks/ios/vision/face_landmarker/sources/MPPFaceLandmarker.mm

@@ -19,7 +19,7 @@
 #import "mediapipe/tasks/ios/common/utils/sources/NSString+Helpers.h"
 #import "mediapipe/tasks/ios/core/sources/MPPTaskInfo.h"
 #import "mediapipe/tasks/ios/vision/core/sources/MPPVisionPacketCreator.h"
-#import "mediapipe/tasks/ios/vision/core/sources/MPPVisionTaskRunnerRefactored.h"
+#import "mediapipe/tasks/ios/vision/core/sources/MPPVisionTaskRunner.h"
 #import "mediapipe/tasks/ios/vision/face_landmarker/sources/MPPFaceLandmarksConnections.h"
 #import "mediapipe/tasks/ios/vision/face_landmarker/utils/sources/MPPFaceLandmarkerOptions+Helpers.h"
 #import "mediapipe/tasks/ios/vision/face_landmarker/utils/sources/MPPFaceLandmarkerResult+Helpers.h"

mediapipe/tasks/ios/vision/gesture_recognizer/BUILD

@@ -58,7 +58,7 @@ objc_library(
         "//mediapipe/tasks/ios/core:MPPTaskInfo",
         "//mediapipe/tasks/ios/vision/core:MPPImage",
         "//mediapipe/tasks/ios/vision/core:MPPVisionPacketCreator",
-        "//mediapipe/tasks/ios/vision/core:MPPVisionTaskRunnerRefactored",
+        "//mediapipe/tasks/ios/vision/core:MPPVisionTaskRunner",
         "//mediapipe/tasks/ios/vision/gesture_recognizer/utils:MPPGestureRecognizerOptionsHelpers",
         "//mediapipe/tasks/ios/vision/gesture_recognizer/utils:MPPGestureRecognizerResultHelpers",
     ],

mediapipe/tasks/ios/vision/gesture_recognizer/sources/MPPGestureRecognizer.mm

@@ -18,7 +18,7 @@
 #import "mediapipe/tasks/ios/common/utils/sources/NSString+Helpers.h"
 #import "mediapipe/tasks/ios/core/sources/MPPTaskInfo.h"
 #import "mediapipe/tasks/ios/vision/core/sources/MPPVisionPacketCreator.h"
-#import "mediapipe/tasks/ios/vision/core/sources/MPPVisionTaskRunnerRefactored.h"
+#import "mediapipe/tasks/ios/vision/core/sources/MPPVisionTaskRunner.h"
 #import "mediapipe/tasks/ios/vision/gesture_recognizer/utils/sources/MPPGestureRecognizerOptions+Helpers.h"
 #import "mediapipe/tasks/ios/vision/gesture_recognizer/utils/sources/MPPGestureRecognizerResult+Helpers.h"
 

mediapipe/tasks/ios/vision/hand_landmarker/BUILD

@@ -66,7 +66,7 @@ objc_library(
         "//mediapipe/tasks/ios/core:MPPTaskInfo",
         "//mediapipe/tasks/ios/vision/core:MPPImage",
         "//mediapipe/tasks/ios/vision/core:MPPVisionPacketCreator",
-        "//mediapipe/tasks/ios/vision/core:MPPVisionTaskRunnerRefactored",
+        "//mediapipe/tasks/ios/vision/core:MPPVisionTaskRunner",
         "//mediapipe/tasks/ios/vision/hand_landmarker/utils:MPPHandLandmarkerOptionsHelpers",
         "//mediapipe/tasks/ios/vision/hand_landmarker/utils:MPPHandLandmarkerResultHelpers",
     ],

mediapipe/tasks/ios/vision/hand_landmarker/sources/MPPHandLandmarker.mm

@@ -18,7 +18,7 @@
 #import "mediapipe/tasks/ios/common/utils/sources/NSString+Helpers.h"
 #import "mediapipe/tasks/ios/core/sources/MPPTaskInfo.h"
 #import "mediapipe/tasks/ios/vision/core/sources/MPPVisionPacketCreator.h"
-#import "mediapipe/tasks/ios/vision/core/sources/MPPVisionTaskRunnerRefactored.h"
+#import "mediapipe/tasks/ios/vision/core/sources/MPPVisionTaskRunner.h"
 #import "mediapipe/tasks/ios/vision/hand_landmarker/sources/MPPHandLandmarksConnections.h"
 #import "mediapipe/tasks/ios/vision/hand_landmarker/utils/sources/MPPHandLandmarkerOptions+Helpers.h"
 #import "mediapipe/tasks/ios/vision/hand_landmarker/utils/sources/MPPHandLandmarkerResult+Helpers.h"

mediapipe/tasks/ios/vision/image_classifier/BUILD

@@ -57,7 +57,7 @@ objc_library(
         "//mediapipe/tasks/ios/core:MPPTaskInfo",
         "//mediapipe/tasks/ios/vision/core:MPPImage",
         "//mediapipe/tasks/ios/vision/core:MPPVisionPacketCreator",
-        "//mediapipe/tasks/ios/vision/core:MPPVisionTaskRunnerRefactored",
+        "//mediapipe/tasks/ios/vision/core:MPPVisionTaskRunner",
         "//mediapipe/tasks/ios/vision/image_classifier/utils:MPPImageClassifierOptionsHelpers",
         "//mediapipe/tasks/ios/vision/image_classifier/utils:MPPImageClassifierResultHelpers",
     ],

mediapipe/tasks/ios/vision/image_classifier/sources/MPPImageClassifier.mm

@@ -18,7 +18,7 @@
 #import "mediapipe/tasks/ios/common/utils/sources/NSString+Helpers.h"
 #import "mediapipe/tasks/ios/core/sources/MPPTaskInfo.h"
 #import "mediapipe/tasks/ios/vision/core/sources/MPPVisionPacketCreator.h"
-#import "mediapipe/tasks/ios/vision/core/sources/MPPVisionTaskRunnerRefactored.h"
+#import "mediapipe/tasks/ios/vision/core/sources/MPPVisionTaskRunner.h"
 #import "mediapipe/tasks/ios/vision/image_classifier/utils/sources/MPPImageClassifierOptions+Helpers.h"
 #import "mediapipe/tasks/ios/vision/image_classifier/utils/sources/MPPImageClassifierResult+Helpers.h"
 

mediapipe/tasks/ios/vision/image_segmenter/BUILD

@@ -11,6 +11,7 @@
 # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 # See the License for the specific language governing permissions and
 # limitations under the License.
+
 package(default_visibility = ["//mediapipe/tasks:internal"])
 
 licenses(["notice"])
@@ -54,7 +55,7 @@ objc_library(
         "//mediapipe/tasks/ios/common/utils:NSStringHelpers",
         "//mediapipe/tasks/ios/core:MPPTaskInfo",
         "//mediapipe/tasks/ios/vision/core:MPPImage",
-        "//mediapipe/tasks/ios/vision/core:MPPVisionTaskRunnerRefactored",
+        "//mediapipe/tasks/ios/vision/core:MPPVisionTaskRunner",
         "//mediapipe/tasks/ios/vision/image_segmenter/utils:MPPImageSegmenterOptionsHelpers",
         "//mediapipe/tasks/ios/vision/image_segmenter/utils:MPPImageSegmenterResultHelpers",
     ],

mediapipe/tasks/ios/vision/image_segmenter/sources/MPPImageSegmenter.mm

@@ -17,7 +17,7 @@
 #import "mediapipe/tasks/ios/common/utils/sources/MPPCommonUtils.h"
 #import "mediapipe/tasks/ios/common/utils/sources/NSString+Helpers.h"
 #import "mediapipe/tasks/ios/core/sources/MPPTaskInfo.h"
-#import "mediapipe/tasks/ios/vision/core/sources/MPPVisionTaskRunnerRefactored.h"
+#import "mediapipe/tasks/ios/vision/core/sources/MPPVisionTaskRunner.h"
 #import "mediapipe/tasks/ios/vision/image_segmenter/utils/sources/MPPImageSegmenterOptions+Helpers.h"
 #import "mediapipe/tasks/ios/vision/image_segmenter/utils/sources/MPPImageSegmenterResult+Helpers.h"
 

mediapipe/tasks/ios/vision/object_detector/BUILD

@@ -55,7 +55,7 @@ objc_library(
         "//mediapipe/tasks/ios/core:MPPTaskInfo",
         "//mediapipe/tasks/ios/vision/core:MPPImage",
         "//mediapipe/tasks/ios/vision/core:MPPVisionPacketCreator",
-        "//mediapipe/tasks/ios/vision/core:MPPVisionTaskRunnerRefactored",
+        "//mediapipe/tasks/ios/vision/core:MPPVisionTaskRunner",
         "//mediapipe/tasks/ios/vision/object_detector/utils:MPPObjectDetectorOptionsHelpers",
         "//mediapipe/tasks/ios/vision/object_detector/utils:MPPObjectDetectorResultHelpers",
     ],

mediapipe/tasks/ios/vision/object_detector/sources/MPPObjectDetector.mm

@@ -18,7 +18,7 @@
 #import "mediapipe/tasks/ios/common/utils/sources/NSString+Helpers.h"
 #import "mediapipe/tasks/ios/core/sources/MPPTaskInfo.h"
 #import "mediapipe/tasks/ios/vision/core/sources/MPPVisionPacketCreator.h"
-#import "mediapipe/tasks/ios/vision/core/sources/MPPVisionTaskRunnerRefactored.h"
+#import "mediapipe/tasks/ios/vision/core/sources/MPPVisionTaskRunner.h"
 #import "mediapipe/tasks/ios/vision/object_detector/utils/sources/MPPObjectDetectorOptions+Helpers.h"
 #import "mediapipe/tasks/ios/vision/object_detector/utils/sources/MPPObjectDetectorResult+Helpers.h"