From 5ac995474caca41cf6d7e15610d52c1d2eaa75e2 Mon Sep 17 00:00:00 2001 From: Cassandra de la Cruz-Munoz Date: Sun, 24 Sep 2023 13:06:26 -0400 Subject: [PATCH] style update that is more clear --- VmcMessages/VmcExtBlendVal.cs | 4 ++-- VmcMessages/VmcExtBonePos.cs | 4 ++-- VmcMessages/VmcExtCam.cs | 6 +++--- VmcMessages/VmcExtCon.cs | 12 ++++++------ VmcMessages/VmcExtConfig.cs | 2 +- VmcMessages/VmcExtDevicePos.cs | 4 ++-- VmcMessages/VmcExtKey.cs | 6 +++--- VmcMessages/VmcExtLight.cs | 6 +++--- VmcMessages/VmcExtMidiCcBit.cs | 4 ++-- VmcMessages/VmcExtMidiCcVal.cs | 4 ++-- VmcMessages/VmcExtMidiNote.cs | 8 ++++---- VmcMessages/VmcExtOk.cs | 8 ++++---- VmcMessages/VmcExtOpt.cs | 2 +- VmcMessages/VmcExtRcv.cs | 6 +++--- VmcMessages/VmcExtRemote.cs | 4 ++-- VmcMessages/VmcExtRootPos.cs | 8 ++++---- VmcMessages/VmcExtSetCalibExec.cs | 2 +- VmcMessages/VmcExtSetConfig.cs | 2 +- VmcMessages/VmcExtSetEye.cs | 4 ++-- VmcMessages/VmcExtSetPeriod.cs | 12 ++++++------ VmcMessages/VmcExtSetRes.cs | 2 +- VmcMessages/VmcExtSetShortcut.cs | 2 +- VmcMessages/VmcExtSettingColor.cs | 5 ++--- VmcMessages/VmcExtSettingWin.cs | 8 ++++---- VmcMessages/VmcExtT.cs | 6 +++--- VmcMessages/VmcExtVrm.cs | 6 +++--- VmcMessages/VmcMessage.cs | 8 ++++---- 27 files changed, 72 insertions(+), 73 deletions(-) diff --git a/VmcMessages/VmcExtBlendVal.cs b/VmcMessages/VmcExtBlendVal.cs index e863d52..4a2f5f6 100644 --- a/VmcMessages/VmcExtBlendVal.cs +++ b/VmcMessages/VmcExtBlendVal.cs @@ -23,8 +23,8 @@ namespace godotVmcSharp { public class VmcExtBlendVal : VmcMessage { - public string Name { get; } - public float Value { get; } + public readonly string Name; + public readonly float Value; public VmcExtBlendVal(OscMessage m) : base(m.Address) { if (m.Data.Count != 2) diff --git a/VmcMessages/VmcExtBonePos.cs b/VmcMessages/VmcExtBonePos.cs index ff093da..38842ee 100644 --- a/VmcMessages/VmcExtBonePos.cs +++ b/VmcMessages/VmcExtBonePos.cs @@ -23,8 +23,8 @@ namespace godotVmcSharp { public class VmcExtBonePos : VmcMessage { - public string Name { get; } - public Transform3D Transform { get; } + public readonly string Name; + public readonly Transform3D Transform; public VmcExtBonePos(OscMessage m) : base(m.Address) { diff --git a/VmcMessages/VmcExtCam.cs b/VmcMessages/VmcExtCam.cs index 469b40b..dbe1a88 100644 --- a/VmcMessages/VmcExtCam.cs +++ b/VmcMessages/VmcExtCam.cs @@ -24,9 +24,9 @@ namespace godotVmcSharp class VmcExtCam : VmcMessage { - public string Name { get; } - public Transform3D Transform { get; } - public float Fov { get; } + public readonly string Name; + public readonly Transform3D Transform; + public readonly float Fov; public VmcExtCam(OscMessage m) : base(m.Address) { diff --git a/VmcMessages/VmcExtCon.cs b/VmcMessages/VmcExtCon.cs index 1978091..16b4f86 100644 --- a/VmcMessages/VmcExtCon.cs +++ b/VmcMessages/VmcExtCon.cs @@ -23,12 +23,12 @@ namespace godotVmcSharp { public class VmcExtCon : VmcMessage { - public int Active { get; } - public string Name { get; } - public int IsLeft { get; } - public int IsTouch { get; } - public int IsAxis { get; } - public Vector3 Axis { get; } + public readonly int Active; + public readonly string Name; + public readonly int IsLeft; + public readonly int IsTouch; + public readonly int IsAxis; + public readonly Vector3 Axis; public VmcExtCon(OscMessage m) : base(m.Address) { diff --git a/VmcMessages/VmcExtConfig.cs b/VmcMessages/VmcExtConfig.cs index 034e28f..fef5c03 100644 --- a/VmcMessages/VmcExtConfig.cs +++ b/VmcMessages/VmcExtConfig.cs @@ -23,7 +23,7 @@ namespace godotVmcSharp { public class VmcExtConfig : VmcMessage { - public string Path { get; } + public readonly string Path; public VmcExtConfig(OscMessage m) : base(m.Address) { diff --git a/VmcMessages/VmcExtDevicePos.cs b/VmcMessages/VmcExtDevicePos.cs index cc51e16..abbcf3f 100644 --- a/VmcMessages/VmcExtDevicePos.cs +++ b/VmcMessages/VmcExtDevicePos.cs @@ -23,8 +23,8 @@ namespace godotVmcSharp { public class VmcExtDevicePos : VmcMessage { - public string Serial { get; } - public Transform3D Transform { get; } + public readonly string Serial; + public readonly Transform3D Transform; public VmcExtDevicePos(OscMessage m) : base(m.Address) { diff --git a/VmcMessages/VmcExtKey.cs b/VmcMessages/VmcExtKey.cs index 65e26a7..86aae04 100644 --- a/VmcMessages/VmcExtKey.cs +++ b/VmcMessages/VmcExtKey.cs @@ -23,9 +23,9 @@ namespace godotVmcSharp { public class VmcExtKey : VmcMessage { - public int Active { get; } - public string Name { get; } - public int Keycode { get; } + public readonly int Active; + public readonly string Name; + public readonly int Keycode; public VmcExtKey(OscMessage m) : base(m.Address) { if (m.Data[0].Type != 'i') diff --git a/VmcMessages/VmcExtLight.cs b/VmcMessages/VmcExtLight.cs index 7ca618e..4bdb007 100644 --- a/VmcMessages/VmcExtLight.cs +++ b/VmcMessages/VmcExtLight.cs @@ -24,9 +24,9 @@ namespace godotVmcSharp { public class VmcExtLight : VmcMessage { - public string Name { get; } - public Transform3D Transform { get; } - public Color Color { get; } + public readonly string Name; + public readonly Transform3D Transform; + public readonly Color Color; public VmcExtLight(OscMessage m) : base(m.Address) { diff --git a/VmcMessages/VmcExtMidiCcBit.cs b/VmcMessages/VmcExtMidiCcBit.cs index c62a516..8574740 100644 --- a/VmcMessages/VmcExtMidiCcBit.cs +++ b/VmcMessages/VmcExtMidiCcBit.cs @@ -23,8 +23,8 @@ namespace godotVmcSharp { public class VmcExtMidiCcBit : VmcMessage { - public int Knob { get; } - public int Active { get; } + public readonly int Knob; + public readonly int Active; public VmcExtMidiCcBit(OscMessage m) : base(m.Address) { if (m.Data[0].Type != 'i') diff --git a/VmcMessages/VmcExtMidiCcVal.cs b/VmcMessages/VmcExtMidiCcVal.cs index 51878f6..1f97f3c 100644 --- a/VmcMessages/VmcExtMidiCcVal.cs +++ b/VmcMessages/VmcExtMidiCcVal.cs @@ -23,8 +23,8 @@ namespace godotVmcSharp { public class VmcExtMidiCcVal : VmcMessage { - public int Knob { get; } - public float Value { get; } + public readonly int Knob; + public readonly float Value; public VmcExtMidiCcVal(OscMessage m) : base(m.Address) { if (m.Data[0].Type != 'i') diff --git a/VmcMessages/VmcExtMidiNote.cs b/VmcMessages/VmcExtMidiNote.cs index 7ec35ec..d55697a 100644 --- a/VmcMessages/VmcExtMidiNote.cs +++ b/VmcMessages/VmcExtMidiNote.cs @@ -23,10 +23,10 @@ namespace godotVmcSharp { public class VmcExtMidiNote : VmcMessage { - public int Active { get; } - public int Channel { get; } - public int Note { get; } - public float Velocity { get; } + public readonly int Active; + public readonly int Channel; + public readonly int Note; + public readonly float Velocity; public VmcExtMidiNote(OscMessage m) : base(m.Address) { diff --git a/VmcMessages/VmcExtOk.cs b/VmcMessages/VmcExtOk.cs index 6dbbe67..be3b045 100644 --- a/VmcMessages/VmcExtOk.cs +++ b/VmcMessages/VmcExtOk.cs @@ -24,10 +24,10 @@ namespace godotVmcSharp { public class VmcExtOk : VmcMessage { - public int Loaded { get; } - public int? CalibrationState { get; } - public int? CalibrationMode { get; } - public int? TrackingStatus { get; } + public readonly int Loaded; + public readonly int? CalibrationState; + public readonly int? CalibrationMode; + public readonly int? TrackingStatus; public VmcExtOk(int loaded) : base(new OscAddress("/VMC/Ext/OK")) { diff --git a/VmcMessages/VmcExtOpt.cs b/VmcMessages/VmcExtOpt.cs index 0c01153..59dff8d 100644 --- a/VmcMessages/VmcExtOpt.cs +++ b/VmcMessages/VmcExtOpt.cs @@ -23,7 +23,7 @@ namespace godotVmcSharp { public class VmcExtOpt : VmcMessage { - public string option { get; } + public readonly string option; public VmcExtOpt(OscMessage m) : base(m.Address) { diff --git a/VmcMessages/VmcExtRcv.cs b/VmcMessages/VmcExtRcv.cs index f375697..8ca3dbf 100644 --- a/VmcMessages/VmcExtRcv.cs +++ b/VmcMessages/VmcExtRcv.cs @@ -24,9 +24,9 @@ namespace godotVmcSharp { public class VmcExtRcv : VmcMessage { - public int Enable { get; } - public int Port { get; } - public string IpAddress { get; } + public readonly int Enable; + public readonly int Port; + public readonly string IpAddress; public VmcExtRcv(OscMessage m) : base(m.Address) { diff --git a/VmcMessages/VmcExtRemote.cs b/VmcMessages/VmcExtRemote.cs index 9e8268e..3bf6dff 100644 --- a/VmcMessages/VmcExtRemote.cs +++ b/VmcMessages/VmcExtRemote.cs @@ -23,8 +23,8 @@ namespace godotVmcSharp { public class VmcExtRemote : VmcMessage { - public string Service { get; } - public string Json { get; } + public readonly string Service; + public readonly string Json; public VmcExtRemote(OscMessage m) : base(m.Address) { diff --git a/VmcMessages/VmcExtRootPos.cs b/VmcMessages/VmcExtRootPos.cs index 51854a9..f2ef484 100644 --- a/VmcMessages/VmcExtRootPos.cs +++ b/VmcMessages/VmcExtRootPos.cs @@ -25,11 +25,11 @@ namespace godotVmcSharp { public class VmcExtRootPos : VmcMessage { - public string Name { get; } - public Transform3D Transform { get; } + public readonly string Name; + public readonly Transform3D Transform; - public Vector3? Scale { get; } - public Vector3? Offset { get; } + public readonly Vector3? Scale; + public readonly Vector3? Offset; public VmcExtRootPos(OscMessage m) : base(m.Address) { diff --git a/VmcMessages/VmcExtSetCalibExec.cs b/VmcMessages/VmcExtSetCalibExec.cs index 84884c1..f503412 100644 --- a/VmcMessages/VmcExtSetCalibExec.cs +++ b/VmcMessages/VmcExtSetCalibExec.cs @@ -23,7 +23,7 @@ namespace godotVmcSharp { public class VmcExtSetCalibExec : VmcMessage { - public int Mode { get; } + public readonly int Mode; public VmcExtSetCalibExec(OscMessage m) : base(m.Address) { diff --git a/VmcMessages/VmcExtSetConfig.cs b/VmcMessages/VmcExtSetConfig.cs index b4d37fb..66b7f71 100644 --- a/VmcMessages/VmcExtSetConfig.cs +++ b/VmcMessages/VmcExtSetConfig.cs @@ -23,7 +23,7 @@ namespace godotVmcSharp { public class VmcExtSetConfig : VmcMessage { - public string Path { get; } + public readonly string Path; public VmcExtSetConfig(OscMessage m) : base(m.Address) { diff --git a/VmcMessages/VmcExtSetEye.cs b/VmcMessages/VmcExtSetEye.cs index fa2171e..5c29a25 100644 --- a/VmcMessages/VmcExtSetEye.cs +++ b/VmcMessages/VmcExtSetEye.cs @@ -23,8 +23,8 @@ namespace godotVmcSharp { public class VmcExtSetEye : VmcMessage { - public int Enable { get; } - public Vector3 Position { get; } + public readonly int Enable; + public readonly Vector3 Position; public VmcExtSetEye(OscMessage m) : base(m.Address) { diff --git a/VmcMessages/VmcExtSetPeriod.cs b/VmcMessages/VmcExtSetPeriod.cs index 0724fad..a3cec60 100644 --- a/VmcMessages/VmcExtSetPeriod.cs +++ b/VmcMessages/VmcExtSetPeriod.cs @@ -23,12 +23,12 @@ namespace godotVmcSharp { public class VmcExtSetPeriod : VmcMessage { - public int Status { get; } - public int Root { get; } - public int Bone { get; } - public int BlendShape { get; } - public int Camera { get; } - public int Devices { get; } + public readonly int Status; + public readonly int Root; + public readonly int Bone; + public readonly int BlendShape; + public readonly int Camera; + public readonly int Devices; public VmcExtSetPeriod(OscMessage m) : base(m.Address) { diff --git a/VmcMessages/VmcExtSetRes.cs b/VmcMessages/VmcExtSetRes.cs index 122a4aa..e5e295c 100644 --- a/VmcMessages/VmcExtSetRes.cs +++ b/VmcMessages/VmcExtSetRes.cs @@ -24,7 +24,7 @@ namespace godotVmcSharp { public class VmcExtSetRes : VmcMessage { - public string Response { get; } + public readonly string Response; public VmcExtSetRes(OscMessage m) : base(m.Address) { diff --git a/VmcMessages/VmcExtSetShortcut.cs b/VmcMessages/VmcExtSetShortcut.cs index de9f03c..e7cf77a 100644 --- a/VmcMessages/VmcExtSetShortcut.cs +++ b/VmcMessages/VmcExtSetShortcut.cs @@ -23,7 +23,7 @@ namespace godotVmcSharp { public class VmcExtSetShortcut : VmcMessage { - public string Shortcut { get; } + public readonly string Shortcut; public VmcExtSetShortcut(OscMessage m) : base(m.Address) { diff --git a/VmcMessages/VmcExtSettingColor.cs b/VmcMessages/VmcExtSettingColor.cs index 51de4e1..bbf3ed1 100644 --- a/VmcMessages/VmcExtSettingColor.cs +++ b/VmcMessages/VmcExtSettingColor.cs @@ -18,13 +18,12 @@ using Godot; using godotOscSharp; -using System.Collections.Generic; namespace godotVmcSharp { public class VmcExtSettingColor : VmcMessage { - public Color Color { get; } + public readonly Color Color; public VmcExtSettingColor(OscMessage m) : base(m.Address) { @@ -61,7 +60,7 @@ namespace godotVmcSharp Color = color; } - public OscMessage ToMessage() + public new OscMessage ToMessage() { return new OscMessage(Addr, new System.Collections.Generic.List{ new OscArgument(Color.R, 'f'), diff --git a/VmcMessages/VmcExtSettingWin.cs b/VmcMessages/VmcExtSettingWin.cs index 88b6613..1f5042b 100644 --- a/VmcMessages/VmcExtSettingWin.cs +++ b/VmcMessages/VmcExtSettingWin.cs @@ -23,10 +23,10 @@ namespace godotVmcSharp { public class VmcExtSettingWin : VmcMessage { - public int IsTopMost { get; } - public int IsTransparent { get; } - public int WindowClickThrough { get; } - public int HideBorder { get; } + public readonly int IsTopMost; + public readonly int IsTransparent; + public readonly int WindowClickThrough; + public readonly int HideBorder; public VmcExtSettingWin(OscMessage m) : base(m.Address) { diff --git a/VmcMessages/VmcExtT.cs b/VmcMessages/VmcExtT.cs index 3a2c9f6..906ebdd 100644 --- a/VmcMessages/VmcExtT.cs +++ b/VmcMessages/VmcExtT.cs @@ -23,8 +23,8 @@ namespace godotVmcSharp { public class VmcExtT : VmcMessage { - public float Time { get; } - public VmcExtT(godotOscSharp.OscMessage m) : base(m.Address) + public readonly float Time; + public VmcExtT(OscMessage m) : base(m.Address) { if (m.Data.Count != 1) { @@ -39,7 +39,7 @@ namespace godotVmcSharp Time = (float)m.Data[0].Value; } - public VmcExtT(float time) : base(new godotOscSharp.OscAddress("/VMC/Ext/T")) + public VmcExtT(float time) : base(new OscAddress("/VMC/Ext/T")) { Time = time; } diff --git a/VmcMessages/VmcExtVrm.cs b/VmcMessages/VmcExtVrm.cs index d22acc5..784f5d9 100644 --- a/VmcMessages/VmcExtVrm.cs +++ b/VmcMessages/VmcExtVrm.cs @@ -24,9 +24,9 @@ namespace godotVmcSharp { public class VmcExtVrm : VmcMessage { - public string Path { get; } - public string Title { get; } - public string Hash { get; } + public readonly string Path; + public readonly string Title; + public readonly string Hash; public VmcExtVrm(OscMessage m) : base(m.Address) { diff --git a/VmcMessages/VmcMessage.cs b/VmcMessages/VmcMessage.cs index 356edf1..70a65a5 100644 --- a/VmcMessages/VmcMessage.cs +++ b/VmcMessages/VmcMessage.cs @@ -22,16 +22,16 @@ namespace godotVmcSharp { public class VmcMessage { - public godotOscSharp.OscAddress Addr { get; } + public readonly OscAddress Addr; - public VmcMessage(godotOscSharp.OscAddress address) + public VmcMessage(OscAddress address) { Addr = address; } - public godotOscSharp.OscMessage ToMessage() + public OscMessage ToMessage() { - return new godotOscSharp.OscMessage(Addr); + return new OscMessage(Addr); } } } \ No newline at end of file